From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: pci: reposition braces as per coding style
Date: Fri, 30 Apr 2021 20:12:41 +0300 [thread overview]
Message-ID: <20210430171241.GJ3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <YIw4pUzTOHV6E9WZ@dU2104>
Hi Deepak,
On Fri, Apr 30, 2021 at 10:34:37PM +0530, Deepak R Varma wrote:
> On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote:
> > Hi Deepak,
> >
> > If you're touching all these lines, I might do a little more. Please see
> > the comments below.
> >
> Hello Sakari,
> I can definitely include other changes, but then it will be many different
> types of changes into a single patch. Will that be okay?
>
> I was planning to address one issue per patch as I think the volume of
> change is going to be high. I mentioned that in the notes section of the patch
> message.
I think I'd split the patch into smaller chunks if the result becomes too
big but I don't think it's necessary yet.
Splitting different kinds of simple cleanups into several patches takes
longer time to review when they're touching the same piece of code. As the
chunks in these patches have virtually no dependencies to other chunks,
it's fine to do several kinds of cleanups at once.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-04-30 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 15:40 [PATCH] staging: media: atomisp: pci: reposition braces as per coding style Deepak R Varma
2021-04-30 16:33 ` Sakari Ailus
2021-04-30 17:04 ` Deepak R Varma
2021-04-30 17:12 ` Sakari Ailus [this message]
2021-04-30 17:17 ` Deepak R Varma
2021-05-04 15:48 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430171241.GJ3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).