linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fox Chen <foxhlchen@gmail.com>
To: neilb@suse.de
Cc: Fox Chen <foxhlchen@gmail.com>,
	corbet@lwn.net, vegard.nossum@oracle.com,
	viro@zeniv.linux.org.uk, rdunlap@infradead.org,
	grandmaster@al2klimov.de, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: [PATCH v3 10/13] docs: path-lookup: update WALK_GET, WALK_PUT desc
Date: Thu, 27 May 2021 17:16:15 +0800	[thread overview]
Message-ID: <20210527091618.287093-11-foxhlchen@gmail.com> (raw)
In-Reply-To: <20210527091618.287093-1-foxhlchen@gmail.com>

WALK_GET is changed to WALK_TRAILING with a different meaning.
Here it should be WALK_NOFOLLOW. WALK_PUT dosn't exist, we have
WALK_MORE.

WALK_PUT == !WALK_MORE

And there is not should_follow_link().

Related commits:
commit 8c4efe22e7c4 ("namei: invert the meaning of WALK_FOLLOW")
commit 1c4ff1a87e46 ("namei: invert WALK_PUT logics")

Signed-off-by: Fox Chen <foxhlchen@gmail.com>
---
 Documentation/filesystems/path-lookup.rst | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/filesystems/path-lookup.rst b/Documentation/filesystems/path-lookup.rst
index 0a125673a8fe..08e6306af5b1 100644
--- a/Documentation/filesystems/path-lookup.rst
+++ b/Documentation/filesystems/path-lookup.rst
@@ -1123,13 +1123,13 @@ stack in ``walk_component()`` immediately when the symlink is found;
 old symlink as it walks that last component.  So it is quite
 convenient for ``walk_component()`` to release the old symlink and pop
 the references just before pushing the reference information for the
-new symlink.  It is guided in this by two flags; ``WALK_GET``, which
-gives it permission to follow a symlink if it finds one, and
-``WALK_PUT``, which tells it to release the current symlink after it has been
-followed.  ``WALK_PUT`` is tested first, leading to a call to
-``put_link()``.  ``WALK_GET`` is tested subsequently (by
-``should_follow_link()``) leading to a call to ``pick_link()`` which sets
-up the stack frame.
+new symlink.  It is guided in this by three flags: ``WALK_NOFOLLOW`` which
+forbits it from following a symlink if it finds one, ``WALK_MORE``
+which indicates that it is yet too early to release the
+current symlink, and ``WALK_TRAILING`` which predicates that it is on the final
+component of the lookup, so we will check userspace flag ``LOOKUP_FOLLOW`` to
+decide whether follow it when it is a symlink and call ``may_follow_link()`` to
+check if we have privilege to follow it.
 
 Symlinks with no final component
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- 
2.31.1


  parent reply	other threads:[~2021-05-27  9:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27  9:16 [PATCH v3 00/13] docs: path-lookup: Update pathlookup docs Fox Chen
2021-05-27  9:16 ` [PATCH v3 01/13] docs: path-lookup: update follow_managed() part Fox Chen
2021-05-27  9:16 ` [PATCH v3 02/13] docs: path-lookup: update path_to_nameidata() part Fox Chen
2021-05-27  9:16 ` [PATCH v3 03/13] docs: path-lookup: update path_mountpoint() part Fox Chen
2021-05-27  9:16 ` [PATCH v3 04/13] docs: path-lookup: update do_last() part Fox Chen
2021-05-27  9:16 ` [PATCH v3 05/13] docs: path-lookup: remove filename_mountpoint Fox Chen
2021-05-27  9:16 ` [PATCH v3 06/13] docs: path-lookup: Add macro name to symlink limit description Fox Chen
2021-05-27  9:16 ` [PATCH v3 07/13] docs: path-lookup: i_op->follow_link replaced with i_op->get_link Fox Chen
2021-05-27  9:16 ` [PATCH v3 08/13] docs: path-lookup: update i_op->put_link and cookie description Fox Chen
2021-05-27  9:16 ` [PATCH v3 09/13] docs: path-lookup: no get_link() Fox Chen
2021-05-27  9:16 ` Fox Chen [this message]
2021-06-17 22:31   ` [PATCH v3 10/13] docs: path-lookup: update WALK_GET, WALK_PUT desc NeilBrown
2021-05-27  9:16 ` [PATCH v3 11/13] docs: path-lookup: update get_link() ->follow_link description Fox Chen
2021-05-27  9:16 ` [PATCH v3 12/13] docs: path-lookup: update symlink description Fox Chen
2021-05-27  9:16 ` [PATCH v3 13/13] docs: path-lookup: use bare function() rather than literals Fox Chen
2021-06-17 22:35 ` [PATCH v3 00/13] docs: path-lookup: Update pathlookup docs NeilBrown
2021-06-18  1:00   ` Fox Chen
2021-06-18 17:39 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527091618.287093-11-foxhlchen@gmail.com \
    --to=foxhlchen@gmail.com \
    --cc=corbet@lwn.net \
    --cc=grandmaster@al2klimov.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=rdunlap@infradead.org \
    --cc=vegard.nossum@oracle.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).