From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D580C47082 for ; Thu, 3 Jun 2021 08:12:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A5F9613DA for ; Thu, 3 Jun 2021 08:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229789AbhFCIOf (ORCPT ); Thu, 3 Jun 2021 04:14:35 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:57644 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbhFCIOe (ORCPT ); Thu, 3 Jun 2021 04:14:34 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1loiT5-0005Rj-I2; Thu, 03 Jun 2021 16:12:43 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1loiT0-0000JW-UU; Thu, 03 Jun 2021 16:12:39 +0800 Date: Thu, 3 Jun 2021 16:12:38 +0800 From: Herbert Xu To: Eric Biggers Cc: Liu Shixin , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] crypto: algboss - Replaced simple_strtol() with kstrtouint() Message-ID: <20210603081238.GA1160@gondor.apana.org.au> References: <20210524120834.1580343-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 02:57:50PM -0700, Eric Biggers wrote: > > It would be better to just remove all the code related to CRYPTOA_U32 and > crypto_attr_u32, as it is never used. I agree, it's been unused for over a decade. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt