From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28A7C2B9F4 for ; Sat, 19 Jun 2021 07:53:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86E206112D for ; Sat, 19 Jun 2021 07:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233386AbhFSHzQ (ORCPT ); Sat, 19 Jun 2021 03:55:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229466AbhFSHzP (ORCPT ); Sat, 19 Jun 2021 03:55:15 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D553FC061574 for ; Sat, 19 Jun 2021 00:53:03 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id k22-20020a17090aef16b0290163512accedso8222799pjz.0 for ; Sat, 19 Jun 2021 00:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1bpEKkPGaDRZ2i2zElzyPvoyYFZBlfMCpVCs6DcykY0=; b=DdJE62WiwKorwacDUxAbgWndliyBUKIrtL8f5f0Fs2hO0dT1wTLLccDVmi1ILjGcFE CYZY+cKWN/XRxINF5rAaz6x3pvJLRCnJtkGOfJK2+R0vtbhjG+kBzlBiB1lMT8WKqVJd eOxKubzcktWAnox6dgYmlYsCV5jh2S2zfjtXrlOZuNiXbHQgxqEo/JilkSBdBEF3tRc9 A5avTHPOwYvaF5TS3RyvTU+7eLwrO2v7pMUUxwHacTfjWrH37+UiLTx+vLBQf3SWUDME vcaai/JWvNTU3TmYJQ8f9hhX+gfxhju4m4d1ZEvIQ7rU9fwbNvQBK3pF5fxUoQby3AO6 jfrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1bpEKkPGaDRZ2i2zElzyPvoyYFZBlfMCpVCs6DcykY0=; b=Td4/Jj4dquM4WsAkQGxOzobzAskanpzV0VvTmUZr1VVoxSdwBFHg3M13LwyebLndSw rW/2r+T4OvFPrxCUSCQABilZRCTtnwymWywRxLXaBlACjWO4DkgyVCk+R88ZMW7bKhUE 81ej1Lw9J+/k3eJz1bc8/BzFm+Af0dLPyJVCR2uUCb2CjoBSY9Db25cuMbmomViXYSxF DwRpr+o9I/PdkcUqVXRBBwZSOZtTLiMuyMV1V9v0F0xoQQsDFLUMD4GM/RUqhEUtU5MY hwLT4AGvzh4l8LuiTEjOJiB+jCgayUzuH8V5/q3moJLmPgk7AHJpjoCzOj1yb38juqOc EoUA== X-Gm-Message-State: AOAM532fwYR169gBXf49lMGauk3gJlbrNMcJjsHJG8f1Cxj/JMtHDH++ T9ix6DrvYuA7iizW8nKXUOTKY8cnhkzgUMAd X-Google-Smtp-Source: ABdhPJxtd5AFAzs6L7dqBzpaNYoW3iIwPMQTDTFaiRcViLVcc5d6prdTsDbkRgetxV0pwPjXZ2msLQ== X-Received: by 2002:a17:902:f784:b029:ef:8e2f:430e with SMTP id q4-20020a170902f784b02900ef8e2f430emr8447935pln.28.1624089183086; Sat, 19 Jun 2021 00:53:03 -0700 (PDT) Received: from jm.lan (1-171-85-235.dynamic-ip.hinet.net. [1.171.85.235]) by smtp.gmail.com with ESMTPSA id x13sm9433189pjh.30.2021.06.19.00.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jun 2021 00:53:02 -0700 (PDT) From: Jhih-Ming Huang To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, maqianga@uniontech.com, marcocesati@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Jhih-Ming Huang Subject: [PATCH v4] rtw_security: fix cast to restricted __le32 Date: Sat, 19 Jun 2021 15:52:55 +0800 Message-Id: <20210619075255.107807-1-fbihjmeric@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the sparse warning of fix cast to restricted __le32. There was a change for replacing private CRC-32 routines with in kernel ones. However, the author used le32_to_cpu to convert crc32_le(), and we should cpu_to_le32. Ths commit also fixes the payload checking by memcmp instead of checking element by element. Signed-off-by: Jhih-Ming Huang --- drivers/staging/rtl8723bs/core/rtw_security.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index a99f439328f1..3a2711e21a0f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -92,7 +92,7 @@ void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe) void rtw_wep_decrypt(struct adapter *padapter, u8 *precvframe) { /* exclude ICV */ - u8 crc[4]; + __le32 crc; signed int length; u32 keylength; u8 *pframe, *payload, *iv, wepkey[16]; @@ -121,7 +121,7 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *precvframe) arc4_crypt(ctx, payload, payload, length); /* calculate icv and compare the icv */ - *((u32 *)crc) = le32_to_cpu(~crc32_le(~0, payload, length - 4)); + crc = cpu_to_le32(~crc32_le(~0, payload, length - 4)); } } @@ -537,7 +537,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) u32 pnh; u8 rc4key[16]; u8 ttkey[16]; - u8 crc[4]; + __le32 crc; signed int length; u8 *pframe, *payload, *iv, *prwskey; @@ -618,10 +618,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) arc4_setkey(ctx, rc4key, 16); arc4_crypt(ctx, payload, payload, length); - *((u32 *)crc) = le32_to_cpu(~crc32_le(~0, payload, length - 4)); + crc = cpu_to_le32(~crc32_le(~0, payload, length - 4)); - if (crc[3] != payload[length - 1] || crc[2] != payload[length - 2] || - crc[1] != payload[length - 3] || crc[0] != payload[length - 4]) + if (memcmp(&crc, payload + length - 4, 4) != 0) res = _FAIL; } else { res = _FAIL; -- 2.32.0.288.g62a8d224e6-goog