From: Huang Ying <ying.huang@intel.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Yang Shi <yang.shi@linux.alibaba.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
Yang Shi <shy828301@gmail.com>, Wei Xu <weixugc@google.com>,
Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
David Rientjes <rientjes@google.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
osalvador <osalvador@suse.de>
Subject: [PATCH -V9 5/9] mm/vmscan: add page demotion counter
Date: Fri, 25 Jun 2021 15:32:00 +0800 [thread overview]
Message-ID: <20210625073204.1005986-6-ying.huang@intel.com> (raw)
In-Reply-To: <20210625073204.1005986-1-ying.huang@intel.com>
From: Yang Shi <yang.shi@linux.alibaba.com>
Account the number of demoted pages.
Add pgdemote_kswapd and pgdemote_direct VM counters showed in
/proc/vmstat.
[ daveh:
- __count_vm_events() a bit, and made them look at the THP
size directly rather than getting data from migrate_pages()
]
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Reviewed-by: Wei Xu <weixugc@google.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: osalvador <osalvador@suse.de>
--
Changes since 202010:
* remove unused scan-control 'demoted' field
---
include/linux/vm_event_item.h | 2 ++
mm/vmscan.c | 5 +++++
mm/vmstat.c | 2 ++
3 files changed, 9 insertions(+)
diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index ae0dd1948c2b..a185cc75ff52 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -33,6 +33,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
PGREUSE,
PGSTEAL_KSWAPD,
PGSTEAL_DIRECT,
+ PGDEMOTE_KSWAPD,
+ PGDEMOTE_DIRECT,
PGSCAN_KSWAPD,
PGSCAN_DIRECT,
PGSCAN_DIRECT_THROTTLE,
diff --git a/mm/vmscan.c b/mm/vmscan.c
index badaf3d4360d..78b3bae71520 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1326,6 +1326,11 @@ static unsigned int demote_page_list(struct list_head *demote_pages,
target_nid, MIGRATE_ASYNC, MR_DEMOTION,
&nr_succeeded);
+ if (current_is_kswapd())
+ __count_vm_events(PGDEMOTE_KSWAPD, nr_succeeded);
+ else
+ __count_vm_events(PGDEMOTE_DIRECT, nr_succeeded);
+
return nr_succeeded;
}
diff --git a/mm/vmstat.c b/mm/vmstat.c
index cccee36b289c..a51fbdcadff5 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1259,6 +1259,8 @@ const char * const vmstat_text[] = {
"pgreuse",
"pgsteal_kswapd",
"pgsteal_direct",
+ "pgdemote_kswapd",
+ "pgdemote_direct",
"pgscan_kswapd",
"pgscan_direct",
"pgscan_direct_throttle",
--
2.30.2
next prev parent reply other threads:[~2021-06-25 7:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 7:31 [PATCH -V9 0/9] Migrate Pages in lieu of discard Huang Ying
2021-06-25 7:31 ` [PATCH -V9 1/9] mm/numa: add node demotion data structure Huang Ying
2021-06-25 7:31 ` [PATCH -V9 2/9] mm/migrate: update node demotion order during on hotplug events Huang Ying
2021-06-25 21:26 ` Dave Hansen
2021-06-25 7:31 ` [PATCH -V9 3/9] mm/migrate: enable returning precise migrate_pages() success count Huang Ying
2021-06-25 7:31 ` [PATCH -V9 4/9] mm/migrate: demote pages during reclaim Huang Ying
2021-06-26 0:21 ` Wei Xu
2021-06-28 1:52 ` Huang, Ying
2021-06-25 7:32 ` Huang Ying [this message]
2021-06-25 7:32 ` [PATCH -V9 6/9] mm/vmscan: add helper for querying ability to age anonymous pages Huang Ying
2021-06-25 7:32 ` [PATCH -V9 7/9] mm/vmscan: Consider anonymous pages without swap Huang Ying
2021-06-26 0:02 ` Wei Xu
2021-06-28 2:56 ` Huang, Ying
2021-06-25 7:32 ` [PATCH -V9 8/9] mm/vmscan: never demote for memcg reclaim Huang Ying
2021-06-25 7:32 ` [PATCH -V9 9/9] mm/migrate: add sysfs interface to enable reclaim migration Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625073204.1005986-6-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shy828301@gmail.com \
--cc=weixugc@google.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).