Re: [PATCH 1/3] asus-wmi: Add panel overdrive functionality

From: kernel test robot <lkp@intel.com>
To: "Luke D. Jones" <luke@ljones.dev>, hdegoede@redhat.com
Cc: kbuild-all@lists.01.org, corentin.chary@gmail.com,
	mgross@linux.intel.com, jdelvare@suse.com, linux@roeck-us.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Luke D. Jones" <luke@ljones.dev>
Subject: Re: [PATCH 1/3] asus-wmi: Add panel overdrive functionality
Date: Mon, 5 Jul 2021 07:48:42 +0800	[thread overview]
Message-ID: <202107050723.olrBFU8S-lkp@intel.com> (raw)
In-Reply-To: <20210704222148.880848-2-luke@ljones.dev>

[-- Attachment #1: Type: text/plain, Size: 2895 bytes --]

Hi "Luke,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luke-D-Jones/Support-for-ASUS-egpu-dpgu-disable-panel-overdrive/20210705-062341
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 28e92f990337b8b4c5fdec47667f8b96089c503e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/b46e8ec7f42ce4b644c43f40218fe853d078f098
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luke-D-Jones/Support-for-ASUS-egpu-dpgu-disable-panel-overdrive/20210705-062341
        git checkout b46e8ec7f42ce4b644c43f40218fe853d078f098
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/platform/x86/asus-wmi.c: In function 'panel_od_check_present':
>> drivers/platform/x86/asus-wmi.c:1242:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
    1242 |  if (result & ASUS_WMI_DSTS_PRESENCE_BIT)
         |  ^~
   drivers/platform/x86/asus-wmi.c:1244:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    1244 |   asus->panel_overdrive = result & ASUS_WMI_DSTS_STATUS_BIT;
         |   ^~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for PHY_SPARX5_SERDES
   Depends on (ARCH_SPARX5 || COMPILE_TEST && OF && HAS_IOMEM
   Selected by
   - SPARX5_SWITCH && NETDEVICES && ETHERNET && NET_VENDOR_MICROCHIP && NET_SWITCHDEV && HAS_IOMEM

vim +/if +1242 drivers/platform/x86/asus-wmi.c

  1226	
  1227	/* Panel Overdrive ************************************************************/
  1228	static int panel_od_check_present(struct asus_wmi *asus)
  1229	{
  1230		u32 result;
  1231		int err;
  1232	
  1233		asus->panel_overdrive_available = false;
  1234	
  1235		err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_PANEL_OD, &result);
  1236		if (err) {
  1237			if (err == -ENODEV)
  1238				return 0;
  1239			return err;
  1240		}
  1241	
> 1242		if (result & ASUS_WMI_DSTS_PRESENCE_BIT)
  1243			asus->panel_overdrive_available = true;
  1244			asus->panel_overdrive = result & ASUS_WMI_DSTS_STATUS_BIT;
  1245	
  1246		return 0;
  1247	}
  1248	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65978 bytes --]