From: kernel test robot <lkp@intel.com>
To: Pavo Banicevic <pavo.banicevic@sartura.hr>,
linux-doc@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, geert+renesas@glider.be,
Max.Merchel@tq-group.com, linux@rempel-privat.de,
daniel@0x0f.com, shawnguo@kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH v8 2/7] drivers: mfd: Add a driver for IEI WT61P803 PUZZLE MCU
Date: Tue, 6 Jul 2021 04:57:09 +0800 [thread overview]
Message-ID: <202107060447.4ktXu9xy-lkp@intel.com> (raw)
In-Reply-To: <20210705134939.28691-3-pavo.banicevic@sartura.hr>
[-- Attachment #1: Type: text/plain, Size: 3050 bytes --]
Hi Pavo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on pavel-linux-leds/for-next lee-mfd/for-mfd-next v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pavo-Banicevic/Add-support-for-the-IEI-WT61P803-PUZZLE-MCU/20210705-215150
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/fd7335dc2a71b541d72f88ca1f251e201790f718
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pavo-Banicevic/Add-support-for-the-IEI-WT61P803-PUZZLE-MCU/20210705-215150
git checkout fd7335dc2a71b541d72f88ca1f251e201790f718
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/mfd/iei-wt61p803-puzzle.c:277:5: warning: no previous prototype for 'iei_wt61p803_puzzle_buzzer' [-Wmissing-prototypes]
277 | int iei_wt61p803_puzzle_buzzer(struct iei_wt61p803_puzzle *mcu, bool long_beep)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/iei_wt61p803_puzzle_buzzer +277 drivers/mfd/iei-wt61p803-puzzle.c
276
> 277 int iei_wt61p803_puzzle_buzzer(struct iei_wt61p803_puzzle *mcu, bool long_beep)
278 {
279 unsigned char *resp_buf = mcu->response_buffer;
280 unsigned char buzzer_cmd[4] = {};
281 size_t reply_size;
282 int ret;
283
284 buzzer_cmd[0] = IEI_WT61P803_PUZZLE_CMD_HEADER_START;
285 buzzer_cmd[1] = IEI_WT61P803_PUZZLE_CMD_FUNCTION_SINGLE;
286 buzzer_cmd[2] = long_beep ? '3' : '2'; /* Buzzer 1.5 / 0.5 second beep */
287
288 mutex_lock(&mcu->lock);
289 ret = iei_wt61p803_puzzle_write_command(mcu, buzzer_cmd, sizeof(buzzer_cmd),
290 resp_buf, &reply_size);
291 if (ret)
292 goto exit;
293
294 if (reply_size != 3) {
295 ret = -EIO;
296 goto exit;
297 }
298
299 if (!(resp_buf[0] == IEI_WT61P803_PUZZLE_CMD_HEADER_START &&
300 resp_buf[1] == IEI_WT61P803_PUZZLE_CMD_RESPONSE_OK &&
301 resp_buf[2] == IEI_WT61P803_PUZZLE_CHECKSUM_RESPONSE_OK)) {
302 ret = -EPROTO;
303 goto exit;
304 }
305 exit:
306 mutex_unlock(&mcu->lock);
307 return ret;
308 }
309
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68183 bytes --]
next prev parent reply other threads:[~2021-07-05 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 13:49 [PATCH v8 0/7] Add support for the IEI WT61P803 PUZZLE MCU Pavo Banicevic
2021-07-05 13:49 ` [PATCH v8 1/7] dt-bindings: Add IEI vendor prefix and IEI WT61P803 PUZZLE driver bindings Pavo Banicevic
2021-07-12 16:04 ` Rob Herring
2021-07-05 13:49 ` [PATCH v8 2/7] drivers: mfd: Add a driver for IEI WT61P803 PUZZLE MCU Pavo Banicevic
2021-07-05 20:57 ` kernel test robot [this message]
2021-07-05 13:49 ` [PATCH v8 3/7] drivers: hwmon: Add the IEI WT61P803 PUZZLE HWMON driver Pavo Banicevic
2021-07-05 16:13 ` Guenter Roeck
2021-07-05 13:49 ` [PATCH v8 4/7] drivers: leds: Add the IEI WT61P803 PUZZLE LED driver Pavo Banicevic
2021-07-05 13:49 ` [PATCH v8 5/7] Documentation/ABI: Add iei-wt61p803-puzzle driver sysfs interface documentation Pavo Banicevic
2021-07-05 13:49 ` [PATCH v8 6/7] Documentation/hwmon: Add iei-wt61p803-puzzle hwmon driver documentation Pavo Banicevic
2021-07-05 16:14 ` Guenter Roeck
2021-07-05 13:49 ` [PATCH v8 7/7] MAINTAINERS: Add an entry for the IEI WT61P803 PUZZLE driver Pavo Banicevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107060447.4ktXu9xy-lkp@intel.com \
--to=lkp@intel.com \
--cc=Max.Merchel@tq-group.com \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kbuild-all@lists.01.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=pavo.banicevic@sartura.hr \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).