From: Steven Rostedt <rostedt@goodmis.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
syzbot+721aa903751db87aa244@syzkaller.appspotmail.com,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ingo Molnar <mingo@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH] tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing
Date: Wed, 7 Jul 2021 18:45:18 -0400 [thread overview]
Message-ID: <20210707184518.618ae497@rorschach.local.home> (raw)
In-Reply-To: <CAEf4BzZPb=cPf9V1Bz+USiq+b5opUTNkj4+CRjXdHcmExW3jVg@mail.gmail.com>
On Wed, 7 Jul 2021 15:12:28 -0700
Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> There doesn't seem to be anything conceptually wrong with attaching
> the same BPF program twice to the same tracepoint. Is it a hard
> requirement to have a unique tp+callback combination, or was it done
> mostly to detect an API misuse? How hard is it to support such use
> cases?
>
> I was surprised to discover this is not supported (though I never had
> a use for this, had to construct a test to see the warning).
The callback is identified by the function and its data combination. If
there's two callbacks calling the same function with the same data on
the same tracepoint, one question is, why? And the second is how do you
differentiate the two?
-- Steve
next prev parent reply other threads:[~2021-07-07 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 13:55 [PATCH] tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing Steven Rostedt
2021-06-29 14:16 ` [syzbot] WARNING in tracepoint_add_func syzbot
2021-07-07 22:12 ` [PATCH] tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing Andrii Nakryiko
2021-07-07 22:45 ` Steven Rostedt [this message]
2021-07-07 23:49 ` Andrii Nakryiko
2021-07-08 0:05 ` Steven Rostedt
2021-07-08 0:23 ` Andrii Nakryiko
2021-07-08 0:43 ` Steven Rostedt
2021-07-08 20:04 ` Andrii Nakryiko
2021-07-08 17:30 ` Mathieu Desnoyers
2021-07-08 20:11 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707184518.618ae497@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+721aa903751db87aa244@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).