From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com
Cc: acelan.kao@canonical.com,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
intel-wired-lan@lists.osuosl.org (moderated list:INTEL ETHERNET
DRIVERS), netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/3] e1000e: Make mei_me active when e1000e is in use
Date: Mon, 12 Jul 2021 21:34:58 +0800 [thread overview]
Message-ID: <20210712133500.1126371-2-kai.heng.feng@canonical.com> (raw)
In-Reply-To: <20210712133500.1126371-1-kai.heng.feng@canonical.com>
Many users report rather sluggish RX speed on TGP I219. Since
"intel_idle.max_cstate=1" doesn't help, so it's not caused by deeper
package C-state.
A workaround that always works is to make sure mei_me is runtime active
when e1000e is in use.
The root cause is still unknown, but since many users are affected by
the issue, implment the quirk in the driver as a temporary workaround.
Also adds mei_me as soft dependency to ensure the device link can be
created if e1000e is in initramfs.
BugLink: https://bugs.launchpad.net/bugs/1927925
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213377
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213651
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 5835d6cf2f51..e63445a8ce12 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -7317,6 +7317,27 @@ static const struct net_device_ops e1000e_netdev_ops = {
.ndo_features_check = passthru_features_check,
};
+static void e1000e_create_device_links(struct pci_dev *pdev)
+{
+ struct pci_dev *tgp_mei_me;
+
+ /* Find TGP mei_me devices and make e1000e power depend on mei_me */
+ tgp_mei_me = pci_get_device(PCI_VENDOR_ID_INTEL, 0xa0e0, NULL);
+ if (!tgp_mei_me) {
+ tgp_mei_me = pci_get_device(PCI_VENDOR_ID_INTEL, 0x43e0, NULL);
+ if (!tgp_mei_me)
+ return;
+ }
+
+ if (device_link_add(&pdev->dev, &tgp_mei_me->dev,
+ DL_FLAG_PM_RUNTIME | DL_FLAG_RPM_ACTIVE |
+ DL_FLAG_AUTOREMOVE_CONSUMER))
+ pci_info(pdev, "System and runtime PM depends on %s\n",
+ pci_name(tgp_mei_me));
+
+ pci_dev_put(tgp_mei_me);
+}
+
/**
* e1000_probe - Device Initialization Routine
* @pdev: PCI device information struct
@@ -7645,6 +7666,9 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
if (pci_dev_run_wake(pdev) && hw->mac.type != e1000_pch_cnp)
pm_runtime_put_noidle(&pdev->dev);
+ if (hw->mac.type == e1000_pch_tgp)
+ e1000e_create_device_links(pdev);
+
return 0;
err_register:
@@ -7917,6 +7941,8 @@ static void __exit e1000_exit_module(void)
}
module_exit(e1000_exit_module);
+/* Ensure device link can be created if e1000e is in the initramfs. */
+MODULE_SOFTDEP("pre: mei_me");
MODULE_AUTHOR("Intel Corporation, <linux.nics@intel.com>");
MODULE_DESCRIPTION("Intel(R) PRO/1000 Network Driver");
MODULE_LICENSE("GPL v2");
--
2.31.1
next prev parent reply other threads:[~2021-07-12 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 13:34 [PATCH 1/3] e1000e: Separate TGP from SPT Kai-Heng Feng
2021-07-12 13:34 ` Kai-Heng Feng [this message]
2021-07-14 5:39 ` [Intel-wired-lan] [PATCH 2/3] e1000e: Make mei_me active when e1000e is in use Sasha Neftin
2021-07-14 6:28 ` Kai-Heng Feng
2021-07-14 9:05 ` Ruinskiy, Dima
2021-07-14 9:52 ` Kai-Heng Feng
2021-07-18 8:37 ` Sasha Neftin
2021-07-12 13:34 ` [PATCH 3/3] e1000e: Serialize TGP e1000e PM ops Kai-Heng Feng
2021-07-27 6:53 ` Kai-Heng Feng
2021-08-01 4:15 ` Sasha Neftin
2021-07-13 17:58 ` [Intel-wired-lan] [PATCH 1/3] e1000e: Separate TGP from SPT Sasha Neftin
2021-07-14 4:19 ` Kai-Heng Feng
2021-07-14 8:43 ` Sasha Neftin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712133500.1126371-2-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=acelan.kao@canonical.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).