From: Rob Herring <robh@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Peter Chen <peter.chen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>, David Heidelberg <david@ixit.cz>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator
Date: Mon, 12 Jul 2021 09:39:05 -0600 [thread overview]
Message-ID: <20210712153905.GA1980362@robh.at.kernel.org> (raw)
In-Reply-To: <20210704225433.32029-7-digetx@gmail.com>
On Mon, Jul 05, 2021 at 01:54:27AM +0300, Dmitry Osipenko wrote:
> SMB347 can supply power to USB VBUS, which is required by OTG-cable
> devices that want to switch USB port into the host mode. Add USB VBUS
> regulator properties.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../power/supply/summit,smb347-charger.yaml | 28 +++++++++++++++++++
> .../dt-bindings/power/summit,smb347-charger.h | 4 +++
> 2 files changed, 32 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> index 983fc215c1e5..cd3d834f734d 100644
> --- a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> @@ -73,6 +73,24 @@ properties:
> - 1 # SMB3XX_SOFT_TEMP_COMPENSATE_CURRENT Current compensation
> - 2 # SMB3XX_SOFT_TEMP_COMPENSATE_VOLTAGE Voltage compensation
>
> + summit,inok-polarity:
> + description: |
> + Polarity of INOK signal indicating presence of external power supply.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # SMB3XX_SYSOK_INOK_ACTIVE_LOW
> + - 1 # SMB3XX_SYSOK_INOK_ACTIVE_HIGH
> +
> + usb-vbus:
> + $ref: "../../regulator/regulator.yaml#"
> + type: object
unevaluatedProperties: false
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> +
> + properties:
> + summit,needs-inok-toggle:
> + type: boolean
> + description: INOK signal is fixed and polarity needs to be toggled
> + in order to enable/disable output mode.
> +
> allOf:
> - if:
> properties:
> @@ -134,6 +152,7 @@ examples:
> reg = <0x7f>;
>
> summit,enable-charge-control = <SMB3XX_CHG_ENABLE_PIN_ACTIVE_HIGH>;
> + summit,inok-polarity = <SMB3XX_SYSOK_INOK_ACTIVE_LOW>;
> summit,chip-temperature-threshold-celsius = <110>;
> summit,mains-current-limit-microamp = <2000000>;
> summit,usb-current-limit-microamp = <500000>;
> @@ -141,6 +160,15 @@ examples:
> summit,enable-mains-charging;
>
> monitored-battery = <&battery>;
> +
> + usb-vbus {
> + regulator-name = "usb_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-min-microamp = <750000>;
> + regulator-max-microamp = <750000>;
> + summit,needs-inok-toggle;
> + };
> };
> };
>
> diff --git a/include/dt-bindings/power/summit,smb347-charger.h b/include/dt-bindings/power/summit,smb347-charger.h
> index d918bf321a71..3205699b5e41 100644
> --- a/include/dt-bindings/power/summit,smb347-charger.h
> +++ b/include/dt-bindings/power/summit,smb347-charger.h
> @@ -16,4 +16,8 @@
> #define SMB3XX_CHG_ENABLE_PIN_ACTIVE_LOW 1
> #define SMB3XX_CHG_ENABLE_PIN_ACTIVE_HIGH 2
>
> +/* Polarity of INOK signal */
> +#define SMB3XX_SYSOK_INOK_ACTIVE_LOW 0
> +#define SMB3XX_SYSOK_INOK_ACTIVE_HIGH 1
> +
> #endif
> --
> 2.32.0
>
>
next prev parent reply other threads:[~2021-07-12 15:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 22:54 [PATCH v3 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7 Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 01/12] dt-bindings: phy: tegra20-usb-phy: Convert to schema Dmitry Osipenko
2021-07-12 15:36 ` Rob Herring
2021-07-04 22:54 ` [PATCH v3 02/12] dt-bindings: phy: tegra20-usb-phy: Document properties needed for OTG mode Dmitry Osipenko
2021-07-12 15:41 ` Rob Herring
2021-07-12 23:33 ` Dmitry Osipenko
2021-07-14 23:10 ` Rob Herring
2021-07-15 15:36 ` Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 03/12] soc/tegra: pmc: Expose USB regmap to all SoCs Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 04/12] usb: phy: tegra: Support OTG mode programming Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 05/12] usb: otg-fsm: Fix hrtimer list corruption Dmitry Osipenko
2021-07-06 0:57 ` Peter Chen
2021-07-06 1:15 ` Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator Dmitry Osipenko
2021-07-12 15:39 ` Rob Herring [this message]
2021-07-13 0:22 ` Dmitry Osipenko
2021-07-14 23:01 ` Rob Herring
2021-07-15 15:29 ` Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 07/12] power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 08/12] power: supply: smb347-charger: Remove caching of charger state Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 09/12] power: supply: smb347-charger: Implement USB VBUS regulator Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 10/12] arm64: tegra132: Add new properties to USB PHY device-tree node Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 11/12] ARM: tegra: Add new properties to USB PHY device-tree nodes Dmitry Osipenko
2021-07-04 22:54 ` [PATCH v3 12/12] ARM: tegra: nexus7: Enable USB OTG mode Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712153905.GA1980362@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=sre@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).