From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel@pengutronix.de,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Heiko Carstens <hca@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH v4 3/5] s390/ccwgroup: Drop if with an always false condition
Date: Tue, 13 Jul 2021 21:35:20 +0200 [thread overview]
Message-ID: <20210713193522.1770306-4-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de>
The driver core only calls a bus remove callback when there is a driver.
So dev->driver is never NULL and the check can safely be removed.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/s390/cio/ccwgroup.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index 9748165e08e9..a6aeab1ea0ae 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -444,8 +444,6 @@ static int ccwgroup_remove(struct device *dev)
struct ccwgroup_device *gdev = to_ccwgroupdev(dev);
struct ccwgroup_driver *gdrv = to_ccwgroupdrv(dev->driver);
- if (!dev->driver)
- return 0;
if (gdrv->remove)
gdrv->remove(gdev);
--
2.30.2
next prev parent reply other threads:[~2021-07-13 19:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 19:35 [PATCH v4 0/5] bus: Make remove callback return void Uwe Kleine-König
2021-07-13 19:35 ` [PATCH v4 1/5] PCI: endpoint: Make struct pci_epf_driver::remove " Uwe Kleine-König
2021-07-13 19:35 ` [PATCH v4 2/5] s390/cio: Make struct css_driver::remove " Uwe Kleine-König
2021-07-13 19:35 ` Uwe Kleine-König [this message]
2021-07-13 19:35 ` [PATCH v4 4/5] s390/scm: Make struct scm_driver::remove " Uwe Kleine-König
2021-07-13 19:35 ` [PATCH v4 5/5] bus: Make remove callback " Uwe Kleine-König
2021-07-14 1:12 ` Finn Thain
2021-07-14 8:44 ` Geert Uytterhoeven
2021-07-14 10:25 ` Sudeep Holla
2021-07-14 19:10 ` Dmitry Torokhov
2021-07-19 8:07 ` Uwe Kleine-König
2021-07-20 20:25 ` Wolfram Sang
2021-07-21 10:09 ` [PATCH v4 0/5] " Greg Kroah-Hartman
2021-07-22 8:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713193522.1770306-4-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).