From: Uladzislau Rezki <urezki@gmail.com>
To: Chen Wandun <chenwandun@huawei.com>
Cc: akpm@linux-foundation.org, serapheim.dimitro@delphix.com,
urezki@gmail.com, wangkefeng.wang@huawei.com,
weiyongjun1@huawei.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] mm/vmalloc: fix wrong behavior in vread
Date: Thu, 15 Jul 2021 12:58:13 +0200 [thread overview]
Message-ID: <20210715105813.GA1879@pc638.lan> (raw)
In-Reply-To: <20210714015959.3204871-1-chenwandun@huawei.com>
On Wed, Jul 14, 2021 at 09:59:59AM +0800, Chen Wandun wrote:
> commit f608788cd2d6 ("mm/vmalloc: use rb_tree instead of list for vread()
> lookups") use rb_tree instread of list to speed up lookup, but function
> __find_vmap_area is try to find a vmap_area that include target address,
> if target address is smaller than the leftmost node in vmap_area_root,
> it will return NULL, then vread will read nothing. This behavior is
> different from the primitive semantics.
>
> The correct way is find the first vmap_are that bigger than target addr,
> that is what function find_vmap_area_exceed_addr does.
>
> Fixes: f608788cd2d6 ("mm/vmalloc: use rb_tree instead of list for vread() lookups")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> ---
> mm/vmalloc.c | 29 ++++++++++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index d5cd52805149..47c3a551b6dc 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -787,6 +787,28 @@ unsigned long vmalloc_nr_pages(void)
> return atomic_long_read(&nr_vmalloc_pages);
> }
>
> +static struct vmap_area *find_vmap_area_exceed_addr(unsigned long addr)
> +{
> + struct vmap_area *va = NULL;
> + struct rb_node *n = vmap_area_root.rb_node;
> +
> + while (n) {
> + struct vmap_area *tmp;
> +
> + tmp = rb_entry(n, struct vmap_area, rb_node);
> + if (tmp->va_end > addr) {
> + va = tmp;
> + if (tmp->va_start <= addr)
> + break;
> +
> + n = n->rb_left;
> + } else
> + n = n->rb_right;
> + }
> +
> + return va;
> +}
> +
Can we combine pvm_find_va_enclose_addr() with your new function
making it as one function? The aim is to reduce copy-paste and
not create such new "find" functions.
The pvm_find_va_enclose_addr() seems does the same but only in
reverse order. So something like:
find_vmap_area_exceed_addr(bool reverse)
Thanks!
--
Vlad Rezki
next prev parent reply other threads:[~2021-07-15 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 1:59 [PATCH] mm/vmalloc: fix wrong behavior in vread Chen Wandun
2021-07-14 23:29 ` Andrew Morton
2021-07-15 2:03 ` Chen Wandun
2021-07-15 10:58 ` Uladzislau Rezki [this message]
2021-07-15 12:44 ` Chen Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715105813.GA1879@pc638.lan \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chenwandun@huawei.com \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=serapheim.dimitro@delphix.com \
--cc=wangkefeng.wang@huawei.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).