From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: <Michael.Hennerich@analog.com>, <alexandru.ardelean@analog.com>,
<jic23@kernel.org>, <devicetree@vger.kernel.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lars@metafoo.de>, <Dragos.Bogdan@analog.com>,
<Darius.Berghe@analog.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in trivial-devices
Date: Fri, 23 Jul 2021 17:29:02 +0100 [thread overview]
Message-ID: <20210723172902.00004151@Huawei.com> (raw)
In-Reply-To: <20210722062155.32998-2-puranjay12@gmail.com>
On Thu, 22 Jul 2021 11:51:53 +0530
Puranjay Mohan <puranjay12@gmail.com> wrote:
> Add ADXL355, a 3-Axis MEMS Accelerometer into trivial-devices.yaml.
>
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
Hi Puranjay,
So, a binding should include (as well as we can) all hardware elements,
not just those currently supported by the driver.
This particular device has two interrupts + a dataready signal which is
effectively another interrupt. It also has dual power supplies.
That makes it a rather non-trivial device from the point of view of
bindings. Hence, please give it a file of it's own and also document
the interrupt and supply elements.
Jonathan
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 8341e9d23..0097d6e81 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -41,6 +41,8 @@ properties:
> - adi,adp5589
> # +/-1C TDM Extended Temp Range I.C
> - adi,adt7461
> + # ADXL355:- 3-Axis Low noise MEMS Accelerometer.
> + - adi,adxl355
> # +/-1C TDM Extended Temp Range I.C
> - adt7461
> # AMS iAQ-Core VOC Sensor
next prev parent reply other threads:[~2021-07-23 16:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 6:21 [PATCH v2 0/2] iio: accel: add support for ADXL355 Puranjay Mohan
2021-07-22 6:21 ` [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in trivial-devices Puranjay Mohan
2021-07-23 16:29 ` Jonathan Cameron [this message]
2021-07-24 15:46 ` Puranjay Mohan
2021-07-22 6:21 ` [PATCH v2 2/2] iio: accel: Add driver support for ADXL355 Puranjay Mohan
2021-07-22 7:10 ` Alexandru Ardelean
2021-07-23 16:28 ` Jonathan Cameron
2021-07-23 17:10 ` Jonathan Cameron
2021-07-23 17:14 ` Mark Brown
2021-07-23 17:44 ` Jonathan Cameron
2021-07-23 17:47 ` Mark Brown
2021-07-24 15:53 ` Puranjay Mohan
2021-07-25 15:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723172902.00004151@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Darius.Berghe@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).