From: Sakari Ailus <sakari.ailus@iki.fi>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
devicetree@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v3] dt-binding: media: document ON Semi AR0521 sensor bindings
Date: Tue, 27 Jul 2021 13:58:30 +0300 [thread overview]
Message-ID: <20210727105830.GH3@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <m3o8aoavrv.fsf@t19.piap.pl>
Hi Krzysztof,
On Tue, Jul 27, 2021 at 12:36:20PM +0200, Krzysztof Hałasa wrote:
> Hi Laurent,
>
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
>
> >> + properties:
> >> + data-lanes:
> >> + anyOf:
> >> + - items:
> >> + - const: 1
> >> + - items:
> >> + - const: 1
> >> + - const: 2
> >> + - items:
> >> + - const: 1
> >> + - const: 2
> >> + - const: 3
> >> + - const: 4
> >
> > As the sensor also supports an HiSPi output, I would add the bus-type
> > property:
> >
> > data-lanes:
> > const: 4
>
> Is there any example of this? I'm not sure how should it it look like.
> Something like the following?
>
> properties:
> data-lanes:
> anyOf:
> - items:
> - const: 1
> - items:
> - const: 1
> - const: 2
> - items:
> - const: 1
> - const: 2
> - const: 3
> - const: 4
> bus-type:
> data-lanes:
> const: 4
I think Laurent meant:
bus-type:
const: 4
This way the bindings can be later amended with HiSPi support without
relying on defaults. Albeit the other busses in practice almost never end
up being used even if supported, apart from the standard BT.601, BT.656 and
CSI-2.
Either way is fine IMO.
>
> And... HiSPi would need additional code in the driver. And preferably
> some testing. I think I'd prefer to have DT and the driver staying in
> some sort of sync. Also, I'm uncertain about the syntax and the meaning
> of such, apparently redundant, construct. Nor about its relation to
> HiSPi. An example would be welcome.
No need to add support for the driver.
--
Sakari Ailus
next prev parent reply other threads:[~2021-07-27 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 8:06 [RFC v3] dt-binding: media: document ON Semi AR0521 sensor bindings Krzysztof Hałasa
2021-07-26 22:45 ` Rob Herring
2021-07-27 1:08 ` Laurent Pinchart
2021-07-27 10:36 ` Krzysztof Hałasa
2021-07-27 10:58 ` Sakari Ailus [this message]
2021-07-27 11:03 ` Krzysztof Hałasa
2021-07-30 7:12 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727105830.GH3@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=khalasa@piap.pl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).