From: kernel test robot <lkp@intel.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, maz@kernel.org, will@kernel.org,
catalin.marinas@arm.com, james.morse@arm.com,
julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com,
jean-philippe@linaro.org
Subject: Re: [PATCH v3 3/4] KVM: arm64: Align the VMID allocation with the arm64 ASID one
Date: Thu, 29 Jul 2021 22:59:57 +0800 [thread overview]
Message-ID: <202107292201.vXgUOWRL-lkp@intel.com> (raw)
In-Reply-To: <20210729104009.382-4-shameerali.kolothum.thodi@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 4504 bytes --]
Hi Shameer,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvmarm/next]
[also build test WARNING on arm64/for-next/core arm/for-next soc/for-next rockchip/for-next shawnguo/for-next clk/clk-next v5.14-rc3 next-20210728]
[cannot apply to xlnx/master keystone/next linux-rpi/for-rpi-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shameer-Kolothum/kvm-arm-New-VMID-allocator-based-on-asid/20210729-184607
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3ffbfe2e26ad324870b87a46b930a9a4c0a8faa1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shameer-Kolothum/kvm-arm-New-VMID-allocator-based-on-asid/20210729-184607
git checkout 3ffbfe2e26ad324870b87a46b930a9a4c0a8faa1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
arch/arm64/kvm/vmid.c: In function 'kvm_arm_vmid_update':
>> arch/arm64/kvm/vmid.c:122:15: warning: variable 'cpu' set but not used [-Wunused-but-set-variable]
122 | unsigned int cpu;
| ^~~
vim +/cpu +122 arch/arm64/kvm/vmid.c
0537d0e3bea2fa Shameer Kolothum 2021-07-29 118
0537d0e3bea2fa Shameer Kolothum 2021-07-29 119 void kvm_arm_vmid_update(struct kvm_vmid *kvm_vmid)
0537d0e3bea2fa Shameer Kolothum 2021-07-29 120 {
0537d0e3bea2fa Shameer Kolothum 2021-07-29 121 unsigned long flags;
0537d0e3bea2fa Shameer Kolothum 2021-07-29 @122 unsigned int cpu;
0537d0e3bea2fa Shameer Kolothum 2021-07-29 123 u64 vmid, old_active_vmid;
0537d0e3bea2fa Shameer Kolothum 2021-07-29 124
0537d0e3bea2fa Shameer Kolothum 2021-07-29 125 vmid = atomic64_read(&kvm_vmid->id);
0537d0e3bea2fa Shameer Kolothum 2021-07-29 126
0537d0e3bea2fa Shameer Kolothum 2021-07-29 127 /*
0537d0e3bea2fa Shameer Kolothum 2021-07-29 128 * Please refer comments in check_and_switch_context() in
0537d0e3bea2fa Shameer Kolothum 2021-07-29 129 * arch/arm64/mm/context.c.
0537d0e3bea2fa Shameer Kolothum 2021-07-29 130 */
0537d0e3bea2fa Shameer Kolothum 2021-07-29 131 old_active_vmid = atomic64_read(this_cpu_ptr(&active_vmids));
0537d0e3bea2fa Shameer Kolothum 2021-07-29 132 if (old_active_vmid && vmid_gen_match(vmid) &&
0537d0e3bea2fa Shameer Kolothum 2021-07-29 133 atomic64_cmpxchg_relaxed(this_cpu_ptr(&active_vmids),
0537d0e3bea2fa Shameer Kolothum 2021-07-29 134 old_active_vmid, vmid))
0537d0e3bea2fa Shameer Kolothum 2021-07-29 135 return;
0537d0e3bea2fa Shameer Kolothum 2021-07-29 136
0537d0e3bea2fa Shameer Kolothum 2021-07-29 137 raw_spin_lock_irqsave(&cpu_vmid_lock, flags);
0537d0e3bea2fa Shameer Kolothum 2021-07-29 138
0537d0e3bea2fa Shameer Kolothum 2021-07-29 139 /* Check that our VMID belongs to the current generation. */
0537d0e3bea2fa Shameer Kolothum 2021-07-29 140 vmid = atomic64_read(&kvm_vmid->id);
0537d0e3bea2fa Shameer Kolothum 2021-07-29 141 if (!vmid_gen_match(vmid)) {
0537d0e3bea2fa Shameer Kolothum 2021-07-29 142 vmid = new_vmid(kvm_vmid);
0537d0e3bea2fa Shameer Kolothum 2021-07-29 143 atomic64_set(&kvm_vmid->id, vmid);
0537d0e3bea2fa Shameer Kolothum 2021-07-29 144 }
0537d0e3bea2fa Shameer Kolothum 2021-07-29 145
0537d0e3bea2fa Shameer Kolothum 2021-07-29 146 cpu = smp_processor_id();
0537d0e3bea2fa Shameer Kolothum 2021-07-29 147
0537d0e3bea2fa Shameer Kolothum 2021-07-29 148 atomic64_set(this_cpu_ptr(&active_vmids), vmid);
0537d0e3bea2fa Shameer Kolothum 2021-07-29 149 raw_spin_unlock_irqrestore(&cpu_vmid_lock, flags);
0537d0e3bea2fa Shameer Kolothum 2021-07-29 150 }
0537d0e3bea2fa Shameer Kolothum 2021-07-29 151
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77437 bytes --]
next prev parent reply other threads:[~2021-07-29 15:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 10:40 [PATCH v3 0/4] kvm/arm: New VMID allocator based on asid Shameer Kolothum
2021-07-29 10:40 ` [PATCH v3 1/4] KVM: arm64: Introduce a new VMID allocator for KVM Shameer Kolothum
2021-08-03 11:38 ` Will Deacon
2021-08-03 12:12 ` Shameerali Kolothum Thodi
2021-07-29 10:40 ` [PATCH v3 2/4] KVM: arm64: Make VMID bits accessible outside of allocator Shameer Kolothum
2021-07-29 10:40 ` [PATCH v3 3/4] KVM: arm64: Align the VMID allocation with the arm64 ASID one Shameer Kolothum
2021-07-29 14:59 ` kernel test robot [this message]
2021-07-29 10:40 ` [PATCH v3 4/4] KVM: arm64: Clear active_vmids on vCPU schedule out Shameer Kolothum
2021-08-03 11:40 ` Will Deacon
2021-08-03 12:55 ` Shameerali Kolothum Thodi
2021-08-03 15:30 ` Will Deacon
2021-08-03 15:56 ` Shameerali Kolothum Thodi
2021-08-06 12:24 ` Shameerali Kolothum Thodi
2021-08-09 13:09 ` Will Deacon
2021-08-09 13:48 ` Shameerali Kolothum Thodi
2021-08-11 8:47 ` Shameerali Kolothum Thodi
2021-10-11 6:06 ` Shameerali Kolothum Thodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107292201.vXgUOWRL-lkp@intel.com \
--to=lkp@intel.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jean-philippe@linaro.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).