From: "Darrick J. Wong" <djwong@kernel.org>
To: Andreas Gruenbacher <agruenba@redhat.com>,
linux-erofs@lists.ozlabs.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Huang Jianan <huangjianan@oppo.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Christoph Hellwig <hch@lst.de>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v9] iomap: Support file tail packing
Date: Mon, 2 Aug 2021 14:58:36 -0700 [thread overview]
Message-ID: <20210802215836.GB3601405@magnolia> (raw)
In-Reply-To: <YQfh7V0lvLNx0QlR@B-P7TQMD6M-0146.local>
On Mon, Aug 02, 2021 at 08:15:41PM +0800, Gao Xiang wrote:
> Hi Andreas,
>
> On Sun, Aug 01, 2021 at 02:03:33PM +0200, Andreas Gruenbacher wrote:
> > On Tue, Jul 27, 2021 at 5:00 AM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>
> ...
>
> > > +static int iomap_write_begin_inline(struct inode *inode,
> > > + struct page *page, struct iomap *srcmap)
> > > +{
> > > + /* needs more work for the tailpacking case, disable for now */
> >
> > Nit: the comma should be a semicolon or period here.
>
> Sorry for some delay (busy in other things...)
>
> Yeah, that's fine to me, in English contexts it'd be better like that
> (there is some punctuation rule difference between languages.)
>
>
> Hi Darrick,
> Should I resend v10 for this punctuation change or could you kindly
> help revise this?
>
> (btw, would you mind set up a for-next iomap branch so I could rebase
> other EROFS patches on iomap for-next, thank you very much!)
Er... I'll send a group email shortly. Assembling the branch hasn't
been as straightforward as it usually is...
--D
> Thanks,
> Gao Xiang
next prev parent reply other threads:[~2021-08-02 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 2:59 [PATCH v9] iomap: Support file tail packing Gao Xiang
2021-07-27 15:10 ` Darrick J. Wong
2021-07-27 15:23 ` Andreas Grünbacher
2021-07-27 15:30 ` Re: Gao Xiang
2021-08-01 12:03 ` [PATCH v9] iomap: Support file tail packing Andreas Gruenbacher
2021-08-02 12:15 ` Gao Xiang
2021-08-02 21:58 ` Darrick J. Wong [this message]
2021-08-03 0:17 ` [PATCH v10] iomap: support reading inline data from non-zero pos Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802215836.GB3601405@magnolia \
--to=djwong@kernel.org \
--cc=agruenba@redhat.com \
--cc=hch@lst.de \
--cc=huangjianan@oppo.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).