From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, peterx@redhat.com
Subject: Re: [PATCH 4/7] vfio,vfio-pci: Add vma to pfn callback
Date: Thu, 5 Aug 2021 22:01:46 -0300 [thread overview]
Message-ID: <20210806010146.GE1672295@nvidia.com> (raw)
In-Reply-To: <162818326742.1511194.1366505678218237973.stgit@omen>
On Thu, Aug 05, 2021 at 11:07:47AM -0600, Alex Williamson wrote:
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index 1e4fc69fee7d..42ca93be152a 100644
> +++ b/drivers/vfio/vfio.c
> @@ -875,6 +875,22 @@ struct vfio_device *vfio_device_get_from_dev(struct device *dev)
> }
> EXPORT_SYMBOL_GPL(vfio_device_get_from_dev);
>
> +static const struct file_operations vfio_device_fops;
> +
> +int vfio_device_vma_to_pfn(struct vfio_device *device,
> + struct vm_area_struct *vma, unsigned long *pfn)
A comment here describing the locking conditions the caller must meet
would be a good addition.. It looks like this can only work under the
i_mmap_lock and the returned pfn can only be taken outside that lock
if it is placed in a VMA
Maybe this is not a great API then? Should it be 'populate vma' and
call io_remap_pfn_range under the op?
Jason
next prev parent reply other threads:[~2021-08-06 1:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 17:06 [PATCH 0/7] vfio: device fd address space and vfio-pci mmap invalidation cleanup Alex Williamson
2021-08-05 17:07 ` [PATCH 1/7] vfio: Create vfio_fs_type with inode per device Alex Williamson
2021-08-10 8:43 ` Christoph Hellwig
2021-08-10 14:52 ` Alex Williamson
2021-08-10 14:57 ` Christoph Hellwig
2021-08-10 18:49 ` Peter Xu
2021-08-10 21:16 ` Alex Williamson
2021-08-10 22:18 ` Peter Xu
2021-08-05 17:07 ` [PATCH 2/7] vfio: Export unmap_mapping_range() wrapper Alex Williamson
2021-08-10 8:45 ` Christoph Hellwig
2021-08-10 18:56 ` Peter Xu
2021-08-05 17:07 ` [PATCH 3/7] vfio/pci: Use vfio_device_unmap_mapping_range() Alex Williamson
2021-08-06 1:04 ` Jason Gunthorpe
2021-08-06 20:17 ` Alex Williamson
2021-08-10 8:51 ` Christoph Hellwig
2021-08-10 11:57 ` Jason Gunthorpe
2021-08-10 12:55 ` Christoph Hellwig
2021-08-10 21:50 ` Alex Williamson
2021-08-11 11:57 ` Jason Gunthorpe
2021-08-10 8:53 ` Christoph Hellwig
2021-08-10 19:02 ` Peter Xu
2021-08-10 20:51 ` Alex Williamson
2021-08-10 18:48 ` Peter Xu
2021-08-10 19:59 ` Alex Williamson
2021-08-10 20:20 ` Peter Xu
2021-08-05 17:07 ` [PATCH 4/7] vfio,vfio-pci: Add vma to pfn callback Alex Williamson
2021-08-06 1:01 ` Jason Gunthorpe [this message]
2021-08-10 9:00 ` Christoph Hellwig
2021-08-10 9:00 ` Christoph Hellwig
2021-08-05 17:08 ` [PATCH 5/7] mm/interval_tree.c: Export vma interval tree iterators Alex Williamson
2021-08-05 17:08 ` [PATCH 6/7] vfio: Add vfio_device_io_remap_mapping_range() Alex Williamson
2021-08-10 9:04 ` Christoph Hellwig
2021-08-05 17:08 ` [PATCH 7/7] vfio/pci: Remove map-on-fault behavior Alex Williamson
2021-08-10 9:11 ` Christoph Hellwig
2021-08-10 15:04 ` Alex Williamson
2021-08-10 20:54 ` Peter Xu
2021-08-10 21:45 ` Alex Williamson
2021-08-10 22:27 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806010146.GE1672295@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).