Re: [PATCH v27 08/10] fs/ntfs3: Add Kconfig, Makefile and doc

From: Kari Argillander <kari.argillander@gmail.com>
To: "Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
	"Pali Rohár" <pali.rohar@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz,
	aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org,
	joe@perches.com, mark@harmstone.com, nborisov@suse.com,
	linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com,
	dan.carpenter@oracle.com, hch@lst.de, ebiggers@kernel.org,
	andy.lavr@gmail.com, oleksandr@natalenko.name
Subject: Re: [PATCH v27 08/10] fs/ntfs3: Add Kconfig, Makefile and doc
Date: Tue, 10 Aug 2021 10:47:40 +0300	[thread overview]
Message-ID: <20210810074740.mkjcow2inyjaakch@kari-VirtualBox> (raw)
In-Reply-To: <20210729134943.778917-9-almaz.alexandrovich@paragon-software.com>

On Thu, Jul 29, 2021 at 04:49:41PM +0300, Konstantin Komarov wrote:
> This adds Kconfig, Makefile and doc
> 
> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> ---
>  Documentation/filesystems/ntfs3.rst | 107 ++++++++++++++++++++++++++++

Still missing Documentation/filesystems/index.rst as I stated before
https://lore.kernel.org/linux-fsdevel/20210103220739.2gkh6gy3iatv4fog@kari-VirtualBox/

>  fs/ntfs3/Kconfig                    |  46 ++++++++++++
>  fs/ntfs3/Makefile                   |  36 ++++++++++
>  3 files changed, 189 insertions(+)
>  create mode 100644 Documentation/filesystems/ntfs3.rst
>  create mode 100644 fs/ntfs3/Kconfig
>  create mode 100644 fs/ntfs3/Makefile
> 
> diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystems/ntfs3.rst

> +Mount Options
> +=============
> +
> +The list below describes mount options supported by NTFS3 driver in addition to
> +generic ones.
> +
> +===============================================================================
> +
> +nls=name		This option informs the driver how to interpret path
> +			strings and translate them to Unicode and back. If
> +			this option is not set, the default codepage will be
> +			used (CONFIG_NLS_DEFAULT).
> +			Examples:
> +				'nls=utf8'

It seems that kernel community will start use iocharset= as default. nls
option can still be alias but will need deprecated message. See message
https://lore.kernel.org/linux-fsdevel/20200102211855.gg62r7jshp742d6i@pali/

and current work from Pali
https://lore.kernel.org/linux-fsdevel/20210808162453.1653-1-pali@kernel.org/

This is still RFC state so probably no horry, but good to know stuff. I
also added Pali so he also knows.

> diff --git a/fs/ntfs3/Makefile b/fs/ntfs3/Makefile
> new file mode 100644
> index 000000000..279701b62
> --- /dev/null
> +++ b/fs/ntfs3/Makefile
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Makefile for the ntfs3 filesystem support.
> +#
> +
> +# to check robot warnings
> +ccflags-y += -Wint-to-pointer-cast \
> +	$(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
> +	$(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)

It is good idea to include this url in commit message.
https://lore.kernel.org/linux-fsdevel/212218590.13874.1621431781547@office.mailbox.org/

And also add that signed off tag from Tor Vic.

> +
> +obj-$(CONFIG_NTFS3_FS) += ntfs3.o
> +
> +ntfs3-y :=	attrib.o \
> +		attrlist.o \
> +		bitfunc.o \
> +		bitmap.o \
> +		dir.o \
> +		fsntfs.o \
> +		frecord.o \
> +		file.o \
> +		fslog.o \
> +		inode.o \
> +		index.o \
> +		lznt.o \
> +		namei.o \
> +		record.o \
> +		run.o \
> +		super.o \
> +		upcase.o \
> +		xattr.o
> +
> +ntfs3-$(CONFIG_NTFS3_LZX_XPRESS) += $(addprefix lib/,\
> +		decompress_common.o \
> +		lzx_decompress.o \
> +		xpress_decompress.o \
> +		)
> \ No newline at end of file
> -- 
> 2.25.4
> 