From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7106BC4320A for ; Tue, 10 Aug 2021 09:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47A4560E9B for ; Tue, 10 Aug 2021 09:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238557AbhHJJDD (ORCPT ); Tue, 10 Aug 2021 05:03:03 -0400 Received: from verein.lst.de ([213.95.11.211]:35309 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233739AbhHJJDC (ORCPT ); Tue, 10 Aug 2021 05:03:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 88C5768AFE; Tue, 10 Aug 2021 11:02:34 +0200 (CEST) Date: Tue, 10 Aug 2021 11:02:34 +0200 From: Christoph Hellwig To: Konstantin Komarov Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz, aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org, joe@perches.com, mark@harmstone.com, nborisov@suse.com, linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com, dan.carpenter@oracle.com, hch@lst.de, ebiggers@kernel.org, andy.lavr@gmail.com, kari.argillander@gmail.com, oleksandr@natalenko.name Subject: Re: [PATCH v27 02/10] fs/ntfs3: Add initialization of super block Message-ID: <20210810090234.GA23732@lst.de> References: <20210729134943.778917-1-almaz.alexandrovich@paragon-software.com> <20210729134943.778917-3-almaz.alexandrovich@paragon-software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729134943.778917-3-almaz.alexandrovich@paragon-software.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static struct dentry *ntfs_mount(struct file_system_type *fs_type, int flags, > + const char *dev_name, void *data) > +{ > + return mount_bdev(fs_type, flags, dev_name, data, ntfs_fill_super); > +} > + > +static struct file_system_type ntfs_fs_type = { > + .owner = THIS_MODULE, > + .name = "ntfs3", > + .mount = ntfs_mount, > + .kill_sb = kill_block_super, > + .fs_flags = FS_REQUIRES_DEV, > +}; You can't add new callers of mount_bdev or users of the old mount support. Please switch to the file system context based API before resending. Take a look at e.g. XFS for how to implement it.