From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Joel Becker <jlbec@evilplan.org>,
linux-kernel@vger.kernel.org,
Bodo Stroesser <bostroesser@gmail.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Brendan Higgins <brendanhiggins@google.com>,
Yanko Kaneti <yaneti@declera.com>
Subject: Re: [PATCH v4 3/3] configfs: Add unit tests
Date: Tue, 10 Aug 2021 18:50:29 +0200 [thread overview]
Message-ID: <20210810165029.GA20722@lst.de> (raw)
In-Reply-To: <bcf5fd83-b30a-8887-361e-603821562d9a@acm.org>
On Mon, Aug 09, 2021 at 11:31:23AM -0700, Bart Van Assche wrote:
> I can store this documentation in a new README, but isn't this something
> that has already been explained in
> Documentation/dev-tools/kunit/kunit-tool.rst?
So reference that.
>
> >> +config CONFIGFS_KUNIT_TEST
> >> + bool "Configfs Kunit test" if !KUNIT_ALL_TESTS
> >> + depends on CONFIGFS_FS && KUNIT=y
> >> + default KUNIT_ALL_TESTS
> >
> > Why does it depend on KUNIT=y? What is the issue with a modular KUNIT
> > build?
>
> The unit tests calls do_mount(). do_mount() has not been exported and
> hence is not available to kernel modules. Hence the exclusion of KUNIT=m.
You should probably document that. But then again this is another
big red flag that this code should live in userspace.
> > To me this sounds like userspace would be a better place for these
> > kinds of tests.
>
> Splitting the code that can only be run from inside the kernel (creation
> of configfs attributes) and the code that can be run from user space and
> making sure that the two run in a coordinated fashion would involve a
> significant amount of work. I prefer to keep the current approach.
But userspace is the right place to do this kind of pathname
based file system I/O.
So for the current in-kernel approach:
Nacked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-08-10 16:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 4:35 [PATCH v4 0/3] Restore the kernel v5.13 text attribute write behavior Bart Van Assche
2021-08-05 4:35 ` [PATCH v4 1/3] configfs: " Bart Van Assche
2021-08-05 4:35 ` [PATCH v4 2/3] kunit: Add support for suite initialization and cleanup Bart Van Assche
2021-08-05 4:35 ` [PATCH v4 3/3] configfs: Add unit tests Bart Van Assche
2021-08-09 14:59 ` Christoph Hellwig
2021-08-09 18:31 ` Bart Van Assche
2021-08-10 16:50 ` Christoph Hellwig [this message]
2021-08-10 18:45 ` Bart Van Assche
2021-08-10 20:50 ` Shuah Khan
2021-08-11 9:00 ` Brendan Higgins
2022-03-01 20:03 ` Brendan Higgins
2021-08-10 22:00 ` Brendan Higgins
2021-08-11 3:13 ` Bart Van Assche
2021-08-09 14:56 ` [PATCH v4 0/3] Restore the kernel v5.13 text attribute write behavior Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810165029.GA20722@lst.de \
--to=hch@lst.de \
--cc=bostroesser@gmail.com \
--cc=brendanhiggins@google.com \
--cc=bvanassche@acm.org \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yaneti@declera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).