From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 352E9C432BE for ; Tue, 17 Aug 2021 04:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1650F60F41 for ; Tue, 17 Aug 2021 04:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237142AbhHQEuQ (ORCPT ); Tue, 17 Aug 2021 00:50:16 -0400 Received: from verein.lst.de ([213.95.11.211]:57006 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbhHQEuP (ORCPT ); Tue, 17 Aug 2021 00:50:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 398676736F; Tue, 17 Aug 2021 06:49:40 +0200 (CEST) Date: Tue, 17 Aug 2021 06:49:40 +0200 From: Christoph Hellwig To: Ming Lei Cc: Thomas Gleixner , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 3/7] genirq/affinity: don't pass irq_affinity_desc array to irq_build_affinity_masks Message-ID: <20210817044940.GC3874@lst.de> References: <20210814123532.229494-1-ming.lei@redhat.com> <20210814123532.229494-4-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210814123532.229494-4-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 14, 2021 at 08:35:28PM +0800, Ming Lei wrote: > Prepare for abstracting irq_build_affinity_masks() into one public helper > for assigning all CPUs evenly into several groups. Don't passing s/passing/pass/ > irq_affinity_desc array to irq_build_affinity_masks, instead returning s/returning/return/ > one cpumask array by storing each assigned group into one element of s/one/a/ > the array. > > This way helps us to provide generic interface for grouping all CPUs s/way // Otherwise looks good: Reviewed-by: Christoph Hellwig