From: bongsu.jeon2@gmail.com
To: shuah@kernel.org, krzysztof.kozlowski@canonical.com
Cc: netdev@vger.kernel.org, linux-nfc@lists.01.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Bongsu Jeon <bongsu.jeon@samsung.com>
Subject: [PATCH v2 net-next 6/8] selftests: nci: Add the flags parameter for the send_cmd_mt_nla
Date: Tue, 17 Aug 2021 06:28:16 -0700 [thread overview]
Message-ID: <20210817132818.8275-7-bongsu.jeon2@gmail.com> (raw)
In-Reply-To: <20210817132818.8275-1-bongsu.jeon2@gmail.com>
From: Bongsu Jeon <bongsu.jeon@samsung.com>
To reuse the send_cmd_mt_nla for NLM_F_REQUEST and NLM_F_DUMP flag,
add the flags parameter to the function.
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
---
tools/testing/selftests/nci/nci_dev.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
index a1786cef73bc..2b90379523c6 100644
--- a/tools/testing/selftests/nci/nci_dev.c
+++ b/tools/testing/selftests/nci/nci_dev.c
@@ -87,7 +87,7 @@ static int create_nl_socket(void)
static int send_cmd_mt_nla(int sd, __u16 nlmsg_type, __u32 nlmsg_pid,
__u8 genl_cmd, int nla_num, __u16 nla_type[],
- void *nla_data[], int nla_len[])
+ void *nla_data[], int nla_len[], __u16 flags)
{
struct sockaddr_nl nladdr;
struct msgtemplate msg;
@@ -98,7 +98,7 @@ static int send_cmd_mt_nla(int sd, __u16 nlmsg_type, __u32 nlmsg_pid,
msg.n.nlmsg_len = NLMSG_LENGTH(GENL_HDRLEN);
msg.n.nlmsg_type = nlmsg_type;
- msg.n.nlmsg_flags = NLM_F_REQUEST;
+ msg.n.nlmsg_flags = flags;
msg.n.nlmsg_seq = 0;
msg.n.nlmsg_pid = nlmsg_pid;
msg.g.cmd = genl_cmd;
@@ -146,8 +146,8 @@ static int send_get_nfc_family(int sd, __u32 pid)
nla_get_family_data = family_name;
return send_cmd_mt_nla(sd, GENL_ID_CTRL, pid, CTRL_CMD_GETFAMILY,
- 1, &nla_get_family_type,
- &nla_get_family_data, &nla_get_family_len);
+ 1, &nla_get_family_type, &nla_get_family_data,
+ &nla_get_family_len, NLM_F_REQUEST);
}
static int get_family_id(int sd, __u32 pid)
@@ -189,7 +189,7 @@ static int send_cmd_with_idx(int sd, __u16 nlmsg_type, __u32 nlmsg_pid,
int nla_len = 4;
return send_cmd_mt_nla(sd, nlmsg_type, nlmsg_pid, genl_cmd, 1,
- &nla_type, &nla_data, &nla_len);
+ &nla_type, &nla_data, &nla_len, NLM_F_REQUEST);
}
static int get_nci_devid(int sd, __u16 fid, __u32 pid, int dev_id, struct msgtemplate *msg)
@@ -531,9 +531,9 @@ TEST_F(NCI, start_poll)
(void *)&self->virtual_nci_fd);
ASSERT_GT(rc, -1);
- rc = send_cmd_mt_nla(self->sd, self->fid, self->pid,
- NFC_CMD_START_POLL, 2, nla_start_poll_type,
- nla_start_poll_data, nla_start_poll_len);
+ rc = send_cmd_mt_nla(self->sd, self->fid, self->pid, NFC_CMD_START_POLL, 2,
+ nla_start_poll_type, nla_start_poll_data,
+ nla_start_poll_len, NLM_F_REQUEST);
EXPECT_EQ(rc, 0);
pthread_join(thread_t, (void **)&status);
--
2.32.0
next prev parent reply other threads:[~2021-08-17 13:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 13:28 [PATCH v2 net-next 0/8] Update the virtual NCI device driver and add the NCI testcase bongsu.jeon2
2021-08-17 13:28 ` [PATCH v2 net-next 1/8] nfc: virtual_ncidev: Use wait queue instead of polling bongsu.jeon2
2021-08-17 13:28 ` [PATCH v2 net-next 2/8] selftests: nci: Remove the polling code to read a NCI frame bongsu.jeon2
2021-08-17 13:28 ` [PATCH v2 net-next 3/8] selftests: nci: Fix the typo bongsu.jeon2
2021-08-17 13:28 ` [PATCH v2 net-next 4/8] selftests: nci: Fix the code for next nlattr offset bongsu.jeon2
2021-08-17 13:28 ` [PATCH v2 net-next 5/8] selftests: nci: Fix the wrong condition bongsu.jeon2
2021-08-17 13:28 ` bongsu.jeon2 [this message]
2021-08-17 13:28 ` [PATCH v2 net-next 7/8] selftests: nci: Extract the start/stop discovery function bongsu.jeon2
2021-08-17 13:28 ` [PATCH v2 net-next 8/8] selftests: nci: Add the NCI testcase reading T4T Tag bongsu.jeon2
2021-08-18 9:40 ` [PATCH v2 net-next 0/8] Update the virtual NCI device driver and add the NCI testcase patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817132818.8275-7-bongsu.jeon2@gmail.com \
--to=bongsu.jeon2@gmail.com \
--cc=bongsu.jeon@samsung.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).