From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B883C4338F for ; Wed, 18 Aug 2021 03:32:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D2C36101A for ; Wed, 18 Aug 2021 03:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236113AbhHRDdD (ORCPT ); Tue, 17 Aug 2021 23:33:03 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:53318 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236585AbhHRDdB (ORCPT ); Tue, 17 Aug 2021 23:33:01 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1mGCJI-0005VM-Vt; Wed, 18 Aug 2021 11:32:13 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1mGCJD-00054g-6O; Wed, 18 Aug 2021 11:32:07 +0800 Date: Wed, 18 Aug 2021 11:32:07 +0800 From: Herbert Xu To: Dongliang Mu Cc: Steffen Klassert , "David S. Miller" , Jakub Kicinski , dan.carpenter@oracle.com, syzbot+b9cfd1cc5d57ee0a09ab@syzkaller.appspotmail.com, stable@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: xfrm: assign the per_cpu_ptr pointer before return Message-ID: <20210818033207.GA19350@gondor.apana.org.au> References: <20210818032554.283428-1-mudongliangabcd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818032554.283428-1-mudongliangabcd@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 11:25:53AM +0800, Dongliang Mu wrote: > > diff --git a/net/xfrm/xfrm_ipcomp.c b/net/xfrm/xfrm_ipcomp.c > index cb40ff0ff28d..01dbec70dfba 100644 > --- a/net/xfrm/xfrm_ipcomp.c > +++ b/net/xfrm/xfrm_ipcomp.c > @@ -223,9 +223,9 @@ static void * __percpu *ipcomp_alloc_scratches(void) > void *scratch; > > scratch = vmalloc_node(IPCOMP_SCRATCH_SIZE, cpu_to_node(i)); > + *per_cpu_ptr(scratches, i) = scratch; > if (!scratch) > return NULL; > - *per_cpu_ptr(scratches, i) = scratch; scratches comes from alloc_percpu so it should already be zeroed. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt