From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335CBC4338F for ; Wed, 18 Aug 2021 05:23:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1464260F39 for ; Wed, 18 Aug 2021 05:23:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237653AbhHRFYS (ORCPT ); Wed, 18 Aug 2021 01:24:18 -0400 Received: from verein.lst.de ([213.95.11.211]:60631 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbhHRFYR (ORCPT ); Wed, 18 Aug 2021 01:24:17 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 819C267357; Wed, 18 Aug 2021 07:23:40 +0200 (CEST) Date: Wed, 18 Aug 2021 07:23:40 +0200 From: Christoph Hellwig To: Kari Argillander Cc: Konstantin Komarov , ntfs3@lists.linux.dev, Christoph Hellwig , linux-kernel@vger.kernel.org, Joe Perches Subject: Re: [PATCH v3 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings Message-ID: <20210818052340.GA9053@lst.de> References: <20210818010649.412912-1-kari.argillander@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818010649.412912-1-kari.argillander@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 04:06:46AM +0300, Kari Argillander wrote: > In ntfs3 driver there is allocation made like this ntfs_malloc(). > Patch 2/3 will converter these to kernel ones like kmalloc(). After I > did this then checkpatch raise warnings about array allocations so I > fix these in patch 3/3. > > I also notice when I made patch that there is broken utf8 char so I > wanted first fix that because it raised some warning in my editor and > did not want to "break" patch 2/3. So patch 1/3 address that. I did > try to apply this and it seem to work without issues. So this mostly looks sensible, but I still haven't actually seen the codebase this applies to posted anywhere as far as I can tell.