Re: [PATCH V2 7/7] blk-mq: build default queue map via group_cpus_evenly()

From: kernel test robot <lkp@intel.com>
To: Ming Lei <ming.lei@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jens Axboe <axboe@kernel.dk>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH V2 7/7] blk-mq: build default queue map via group_cpus_evenly()
Date: Wed, 18 Aug 2021 21:01:56 +0800	[thread overview]
Message-ID: <202108182054.WwgIxRQq-lkp@intel.com> (raw)
In-Reply-To: <20210818092812.787558-8-ming.lei@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2357 bytes --]

Hi Ming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on next-20210818]
[cannot apply to block/for-next linux/master linus/master v5.14-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ming-Lei/genirq-affinity-abstract-new-API-from-managed-irq-affinity-spread/20210818-173646
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 04c2721d3530f0723b4c922a8fa9f26b202a20de
config: x86_64-randconfig-c002-20210818 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/5ef5858ae062865d3941a9fc8d6ef024068b36dd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ming-Lei/genirq-affinity-abstract-new-API-from-managed-irq-affinity-spread/20210818-173646
        git checkout 5ef5858ae062865d3941a9fc8d6ef024068b36dd
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: block/blk-mq-cpumap.o: in function `blk_mq_map_queues':
>> block/blk-mq-cpumap.c:24: undefined reference to `group_cpus_evenly'

vim +24 block/blk-mq-cpumap.c

    18	
    19	int blk_mq_map_queues(struct blk_mq_queue_map *qmap)
    20	{
    21		const struct cpumask *masks;
    22		unsigned int queue, cpu;
    23	
  > 24		masks = group_cpus_evenly(qmap->nr_queues);
    25		if (!masks)
    26			goto fallback;
    27	
    28		for (queue = 0; queue < qmap->nr_queues; queue++) {
    29			for_each_cpu(cpu, &masks[queue])
    30				qmap->mq_map[cpu] = qmap->queue_offset + queue;
    31		}
    32		kfree(masks);
    33		return 0;
    34	 fallback:
    35		for_each_possible_cpu(cpu)
    36			qmap->mq_map[cpu] = qmap->queue_offset;
    37		return 0;
    38	}
    39	EXPORT_SYMBOL_GPL(blk_mq_map_queues);
    40	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29474 bytes --]