From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF7BC4338F for ; Fri, 20 Aug 2021 06:06:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8891960F35 for ; Fri, 20 Aug 2021 06:06:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238144AbhHTGGs (ORCPT ); Fri, 20 Aug 2021 02:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232732AbhHTGGp (ORCPT ); Fri, 20 Aug 2021 02:06:45 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43991C061575 for ; Thu, 19 Aug 2021 23:06:08 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id l3so6649469qtk.10 for ; Thu, 19 Aug 2021 23:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RoaMkljyHgS1AidboqHVoPwYgokiMzyEn+N7OSq7Bz4=; b=YOvqmwVAy3VyvO6UUIEAnr/ZZl8CE6w00IOazxDDS3DN5vX33r/3W1s5fZsNGgbHJa pKiGqSD46QagaRdP3WhFDoHte00ZhaRCR31A3EhmlVGu8TaQ0Kby9+1Bz/VXfPL/yK/Q neIZ0anGLf0LyqQZqrIcIOGlkqlJRAoiCk43yqw932WYyoVuqGrXmL+cb3JB9dEYkIdT dIDi4fq/M75307Sc90kujNSbhHEDZs2ib/J9X8opDF2SEWURDZBLgU6bDFMk+XM8pZsn f8NJlY8el9//nOqqMaDt+F/YwJBPclBaya4mS/+DMYX9gNJQKB77bVUgZuV/CqFe6rJJ qk3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RoaMkljyHgS1AidboqHVoPwYgokiMzyEn+N7OSq7Bz4=; b=q1UFn+DnPDjAAOdgbezJbvyion55YG/C5LBM2c4IOIJ75HveupOppY7WyHhMezVI+9 RHWOpYSrE2RjpuQ7BdpPrSqX3ioVth51TRMaNGRXKza54Ru5SSHmyhZkN7Bqv+9JXBr6 c7F63JRTezAlQ4H7Omi0IYXr6rD55krLpyX4saHv0ehxS0I7Azgq2k9wKFXNoLBDnnV5 q5yToShLGeYL8Ac+PgINsCPLJJC+CSvTit6oHY5aTOzQjPWv26APxeO0orf/awI9OlX3 5Yhheq/F1arAeOzaWHF53gBhwxiI2SQ4orPPCcanImafKUedVrglOAHP+GDzO0r3SE4Q 4EGA== X-Gm-Message-State: AOAM532gXc1p4J0XLSIu5UcXOo7ZMcv7uDPF75iH7R0njDJYQioY53E8 BRS5jlsieK39WXnrdQB/Je+6L4UdWsg= X-Google-Smtp-Source: ABdhPJyC/Ludf3TuV3qvCbhgJe8n27OptTdRaU8tu7w0qHt+b3j8tbSzJjNk00i3EJfTw+v3BcMO3w== X-Received: by 2002:ac8:7483:: with SMTP id v3mr15974649qtq.113.1629439567325; Thu, 19 Aug 2021 23:06:07 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id m19sm2163837qtx.84.2021.08.19.23.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 23:06:07 -0700 (PDT) From: CGEL X-Google-Original-From: CGEL To: linux-kernel@vger.kernel.org Cc: jing yangyang , Zeal Robot Subject: [PATCH linux-next] firmware: edd: fix Coccinelle warnings Date: Thu, 19 Aug 2021 23:05:50 -0700 Message-Id: <20210820060550.14285-1-jing.yangyang@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: jing yangyang WARNING !A || A && B is equivalent to !A || B This issue was detected with the help of Coccinelle. Reported-by: Zeal Robot Signed-off-by: jing yangyang --- drivers/firmware/edd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index 14d0970..e8b409e 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -694,8 +694,7 @@ static void edd_populate_dir(struct edd_device * edev) int i; for (i = 0; (attr = edd_attrs[i]) && !error; i++) { - if (!attr->test || - (attr->test && attr->test(edev))) + if (!attr->test || attr->test(edev)) error = sysfs_create_file(&edev->kobj,&attr->attr); } -- 1.8.3.1