linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] trace: Add migrate-disabled counter to tracing output.
Date: Tue, 7 Sep 2021 11:21:28 -0400	[thread overview]
Message-ID: <20210907112128.7e670ad7@gandalf.local.home> (raw)
In-Reply-To: <20210906081343.klxtb652s5aphg4z@linutronix.de>

On Mon, 6 Sep 2021 10:13:43 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> I left that with that XXX on purpose so you can look and comment and say
> how to fix it. The problem I had with preempt_count was that only the
> lower nibble contains the preemption counter. So I thought you could
> easily came up with something how this can be split or taught to only
> expose the lower nibble. I didn't after a few attempts.
> My understanding is that this `preempt_count' is also used in the filter
> tracefs file so something like "preempt_count > 1" > filter would also
> match for migrate_count = 2, preempt_count = 1. You seem to be happy to
> filter in user space.

Right. It will break filtering, and I don't see a good way to handle that.

That said, I'll update the code to handle comparing fields with a mask.
I'll need to do this with the kernel as well.

I'm fine with breaking the filtering on preempt_count over having it just
fail to print it at all.

-- Steve


  reply	other threads:[~2021-09-07 15:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 16:49 [PATCH] trace: Add migrate-disabled counter to tracing output Sebastian Andrzej Siewior
2021-08-06 17:51 ` Steven Rostedt
2021-08-06 18:10   ` Sebastian Andrzej Siewior
2021-08-10 13:26   ` [PATCH v2] " Sebastian Andrzej Siewior
2021-09-02  7:16     ` Sebastian Andrzej Siewior
2021-09-03 22:50       ` Steven Rostedt
2021-09-03 23:42     ` Steven Rostedt
2021-09-06  8:13       ` Sebastian Andrzej Siewior
2021-09-07 15:21         ` Steven Rostedt [this message]
2021-09-07 15:24           ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907112128.7e670ad7@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).