From: Andrew Jones <drjones@redhat.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Peter Shier <pshier@google.com>,
Ricardo Koller <ricarkol@google.com>,
Oliver Upton <oupton@google.com>,
Reiji Watanabe <reijiw@google.com>,
Jing Zhang <jingzhangos@google.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v4 04/18] KVM: arm64: selftests: Introduce ARM64_SYS_KVM_REG
Date: Thu, 9 Sep 2021 09:04:23 +0200 [thread overview]
Message-ID: <20210909070423.5z4eg7wkmswpdi33@gator> (raw)
In-Reply-To: <20210909013818.1191270-5-rananta@google.com>
On Thu, Sep 09, 2021 at 01:38:04AM +0000, Raghavendra Rao Ananta wrote:
> With the inclusion of sysreg.h, that brings in system register
> encodings, it would be redundant to re-define register encodings
> again in processor.h to use it with ARM64_SYS_REG for the KVM
> functions such as set_reg() or get_reg(). Hence, add helper macro,
> ARM64_SYS_KVM_REG, that converts SYS_* definitions in sysreg.h
> into ARM64_SYS_REG definitions.
>
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> ---
> .../selftests/kvm/include/aarch64/processor.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h
> index bed4ffa70905..ac8b63f8aab7 100644
> --- a/tools/testing/selftests/kvm/include/aarch64/processor.h
> +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h
> @@ -26,6 +26,20 @@
>
> #define ID_AA64DFR0_EL1 3, 0, 0, 5, 0
>
> +/*
> + * ARM64_SYS_KVM_REG(sys_reg_id): Helper macro to convert
> + * SYS_* register definitions in sysreg.h to use in KVM
> + * calls such as get_reg() and set_reg().
> + */
> +#define ARM64_SYS_KVM_REG(sys_reg_id) \
> +({ \
> + ARM64_SYS_REG(sys_reg_Op0(sys_reg_id), \
> + sys_reg_Op1(sys_reg_id), \
> + sys_reg_CRn(sys_reg_id), \
> + sys_reg_CRm(sys_reg_id), \
> + sys_reg_Op2(sys_reg_id)); \
> +})
I don't think we need the ({ }), do we? Anyway,
Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks,
drew
> +
> /*
> * Default MAIR
> * index attribute
> --
> 2.33.0.153.gba50c8fa24-goog
>
next prev parent reply other threads:[~2021-09-09 7:04 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 1:38 [PATCH v4 00/18] KVM: arm64: selftests: Introduce arch_timer selftest Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 01/18] KVM: arm64: selftests: Add MMIO readl/writel support Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 02/18] KVM: arm64: selftests: Add sysreg.h Raghavendra Rao Ananta
2021-09-09 2:47 ` Oliver Upton
2021-09-09 6:53 ` Andrew Jones
2021-09-09 16:42 ` Raghavendra Rao Ananta
2021-09-09 17:17 ` Mark Brown
2021-09-09 20:06 ` Raghavendra Rao Ananta
2021-09-10 8:30 ` Mark Brown
2021-09-13 23:38 ` Raghavendra Rao Ananta
2021-09-14 10:39 ` Mark Brown
2021-09-09 1:38 ` [PATCH v4 03/18] KVM: arm64: selftests: Use read/write definitions from sysreg.h Raghavendra Rao Ananta
2021-09-09 2:55 ` Oliver Upton
2021-09-09 6:56 ` Andrew Jones
2021-09-09 16:43 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 04/18] KVM: arm64: selftests: Introduce ARM64_SYS_KVM_REG Raghavendra Rao Ananta
2021-09-09 3:02 ` Oliver Upton
2021-09-09 16:48 ` Raghavendra Rao Ananta
2021-09-09 7:04 ` Andrew Jones [this message]
2021-09-09 16:49 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 05/18] KVM: arm64: selftests: Add support for cpu_relax Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 06/18] KVM: arm64: selftests: Add basic support for arch_timers Raghavendra Rao Ananta
2021-09-09 7:07 ` Andrew Jones
2021-09-09 1:38 ` [PATCH v4 07/18] KVM: arm64: selftests: Add basic support to generate delays Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 08/18] KVM: arm64: selftests: Add support to disable and enable local IRQs Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 09/18] KVM: arm64: selftests: Add guest support to get the vcpuid Raghavendra Rao Ananta
2021-09-09 5:09 ` Oliver Upton
2021-09-09 16:59 ` Raghavendra Rao Ananta
2021-09-09 17:04 ` Oliver Upton
2021-09-09 7:56 ` Andrew Jones
2021-09-09 17:10 ` Raghavendra Rao Ananta
2021-09-10 8:10 ` Andrew Jones
2021-09-10 18:03 ` Raghavendra Rao Ananta
2021-09-13 7:25 ` Andrew Jones
2021-09-12 7:05 ` Reiji Watanabe
2021-09-13 7:35 ` Andrew Jones
2021-09-13 16:51 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 10/18] KVM: arm64: selftests: Add light-weight spinlock support Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 11/18] KVM: arm64: selftests: Add basic GICv3 support Raghavendra Rao Ananta
2021-09-09 5:18 ` Oliver Upton
2021-09-09 16:38 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 12/18] KVM: selftests: Keep track of the number of vCPUs for a VM Raghavendra Rao Ananta
2021-09-09 5:22 ` Oliver Upton
2021-09-09 13:20 ` Andrew Jones
2021-09-09 1:38 ` [PATCH v4 13/18] KVM: selftests: Add support to get the VM's mode Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 14/18] KVM: arm64: selftests: Add host support for vGIC Raghavendra Rao Ananta
2021-09-09 5:32 ` Oliver Upton
2021-09-09 13:34 ` Andrew Jones
2021-09-09 17:25 ` Raghavendra Rao Ananta
2021-09-09 17:20 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 15/18] KVM: arm64: selftests: Add arch_timer test Raghavendra Rao Ananta
2021-09-09 5:51 ` Oliver Upton
2021-09-09 18:03 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 16/18] KVM: arm64: selftests: arch_timer: Support vCPU migration Raghavendra Rao Ananta
2021-09-09 13:45 ` Andrew Jones
2021-09-09 17:33 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 17/18] KVM: arm64: selftests: Replace ARM64_SYS_REG with ARM64_SYS_KVM_REG Raghavendra Rao Ananta
2021-09-09 5:34 ` Oliver Upton
2021-09-09 13:38 ` Andrew Jones
2021-09-09 17:29 ` Raghavendra Rao Ananta
2021-09-09 1:38 ` [PATCH v4 18/18] KVM: selftests: vgic_init: Pull REDIST_REGION_ATTR_ADDR from vgic.h Raghavendra Rao Ananta
2021-09-09 5:36 ` Oliver Upton
2021-09-09 16:41 ` Raghavendra Rao Ananta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909070423.5z4eg7wkmswpdi33@gator \
--to=drjones@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=rananta@google.com \
--cc=reijiw@google.com \
--cc=ricarkol@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).