From: Mark Brown <broonie@kernel.org>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: sound: add rockchip i2s-tdm binding
Date: Wed, 15 Sep 2021 15:10:12 +0100 [thread overview]
Message-ID: <20210915141012.GC12513@sirena.org.uk> (raw)
In-Reply-To: <20210903231536.225540-3-frattaroli.nicolas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On Sat, Sep 04, 2021 at 01:15:34AM +0200, Nicolas Frattaroli wrote:
> + rockchip,frame-width:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 64
> + minimum: 32
> + maximum: 512
> + description:
> + Width of a frame, usually slot width multiplied by number of slots.
> + Must be even.
Why is this in the binding? This is normally configured by the machine
driver setting the TDM slots, not through DT.
> + rockchip,mclk-calibrate:
> + description:
> + Switch between two root clocks depending on the audio sample rate.
> + For integer multiples of 8000 (e.g. 48000 Hz), mclk_root0 is used.
> + For integer multiples of 11025 (e.g. 44100 Hz), mclk_root1 is used.
> + type: boolean
Why would we not want to do this, and assuming it's to do with
availability can't we detect it simply through seeing if both MCLKs are
available?
> + rockchip,tdm-fsync-half-frame:
> + description: Whether to use half frame fsync.
> + type: boolean
> +
Why is this not part of the normal bus format configuration? I don't
know what this is but it sounds a lot like I2S mode...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-15 14:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 23:15 [PATCH v4 0/4] Rockchip I2S/TDM controller Nicolas Frattaroli
2021-09-03 23:15 ` [PATCH v4 1/4] ASoC: rockchip: add support for i2s-tdm controller Nicolas Frattaroli
2021-09-15 14:05 ` Mark Brown
2021-09-15 14:12 ` Mark Brown
2021-09-03 23:15 ` [PATCH v4 2/4] dt-bindings: sound: add rockchip i2s-tdm binding Nicolas Frattaroli
2021-09-08 12:08 ` Rob Herring
2021-09-15 14:10 ` Mark Brown [this message]
2021-09-15 17:06 ` Nicolas Frattaroli
2021-09-16 12:25 ` Mark Brown
2021-09-19 17:38 ` Nicolas Frattaroli
2021-09-20 11:49 ` Mark Brown
2021-09-03 23:15 ` [PATCH v4 3/4] arm64: dts: rockchip: add i2s1 on rk356x Nicolas Frattaroli
2021-09-03 23:15 ` [PATCH v4 4/4] arm64: dts: rockchip: add analog audio on Quartz64 Nicolas Frattaroli
2021-09-07 13:40 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915141012.GC12513@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).