Hi! > [ Upstream commit 7d6588931ccd4c09e70a08175cf2e0cf7fc3b869 ] > > Commit 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support") has switched to a > managed version when dealing with 'mpc8xxx_gc->regs'. So the corresponding > 'iounmap()' call in the error handling path and in the remove should be > removed to avoid a double unmap. This is wrong, AFAICT. 5.10 does not have 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support") so iounmap is still neccessary and this adds a memory leak. Best regards, Pavel -- 'DENX Software Engineering GmbH, Managing Director: Wolfgang Denk' 'HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany'