From: Christian Brauner <christian.brauner@ubuntu.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: hdanton@sina.com, hch@infradead.org, stefanha@redhat.com,
jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com,
virtualization@lists.linux-foundation.org, axboe@kernel.dk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 7/9] fork: Add worker flag to ignore signals
Date: Wed, 22 Sep 2021 14:52:36 +0200 [thread overview]
Message-ID: <20210922125236.7cb77rxbwkv7x4zj@wittgenstein> (raw)
In-Reply-To: <20210921215218.89844-8-michael.christie@oracle.com>
On Tue, Sep 21, 2021 at 04:52:16PM -0500, Mike Christie wrote:
> The kthread API creates threads that ignore all signals by default so
> modules like vhost that will move from that API to kernel_worker will
> not be expecting them. This patch adds a worker flag that tells
> kernel_worker to setup the task to ignore signals.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
Looks good,
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> include/linux/sched/task.h | 1 +
> kernel/fork.c | 11 ++++++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
> index 781abbc1c288..aefa0d221b57 100644
> --- a/include/linux/sched/task.h
> +++ b/include/linux/sched/task.h
> @@ -21,6 +21,7 @@ struct css_set;
> #define KERN_WORKER_IO BIT(0)
> #define KERN_WORKER_USER BIT(1)
> #define KERN_WORKER_NO_FILES BIT(2)
> +#define KERN_WORKER_NO_SIGS BIT(3)
>
> struct kernel_clone_args {
> u64 flags;
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 3f3fcabffa5f..34d3dca70cfb 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2555,6 +2555,8 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
> struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node,
> unsigned long clone_flags, u32 worker_flags)
> {
> + struct task_struct *tsk;
> +
> struct kernel_clone_args args = {
> .flags = ((lower_32_bits(clone_flags) | CLONE_VM |
> CLONE_UNTRACED) & ~CSIGNAL),
> @@ -2564,7 +2566,14 @@ struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node,
> .worker_flags = KERN_WORKER_USER | worker_flags,
> };
>
> - return copy_process(NULL, 0, node, &args);
> + tsk = copy_process(NULL, 0, node, &args);
> + if (IS_ERR(tsk))
> + return tsk;
> +
> + if (worker_flags & KERN_WORKER_NO_SIGS)
> + ignore_signals(tsk);
> +
> + return tsk;
> }
> EXPORT_SYMBOL_GPL(kernel_worker);
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-09-22 12:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 21:52 [PATCH V2 0/9] Use copy_process/create_io_thread in vhost layer Mike Christie
2021-09-21 21:52 ` [PATCH V2 1/9] fork: Make IO worker options flag based Mike Christie
2021-09-22 12:44 ` Christian Brauner
2021-09-21 21:52 ` [PATCH V2 2/9] fork: pass worker_flags to copy_thread Mike Christie
2021-09-22 12:42 ` Christian Brauner
2021-09-22 14:18 ` Geert Uytterhoeven
2021-09-21 21:52 ` [PATCH V2 3/9] fork: move PF_IO_WORKER's kernel frame setup to new flag Mike Christie
2021-09-22 12:32 ` Geert Uytterhoeven
2021-09-22 12:39 ` Christian Brauner
2021-09-22 12:45 ` Christian Brauner
2021-09-21 21:52 ` [PATCH V2 4/9] fork: add option to not clone or dup files Mike Christie
2021-09-22 12:46 ` Christian Brauner
2021-09-21 21:52 ` [PATCH V2 5/9] fork: add helper to clone a process Mike Christie
2021-09-22 12:50 ` Christian Brauner
2021-09-21 21:52 ` [PATCH V2 6/9] io_uring: switch to kernel_worker Mike Christie
2021-09-22 12:53 ` Christian Brauner
2021-09-21 21:52 ` [PATCH V2 7/9] fork: Add worker flag to ignore signals Mike Christie
2021-09-22 12:52 ` Christian Brauner [this message]
2021-09-21 21:52 ` [PATCH V2 8/9] vhost: move worker thread fields to new struct Mike Christie
2021-10-04 13:12 ` Michael S. Tsirkin
2021-09-21 21:52 ` [PATCH V2 9/9] vhost: use kernel_worker to check RLIMITs and inherit v2 cgroups Mike Christie
2021-10-04 13:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922125236.7cb77rxbwkv7x4zj@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=hdanton@sina.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).