From: Jakub Kicinski <kuba@kernel.org>
To: Toms Atteka <cpp.code.lv@gmail.com>
Cc: netdev@vger.kernel.org, pshelar@ovn.org, davem@davemloft.net,
dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6] net: openvswitch: IPv6: Add IPv6 extension header support
Date: Tue, 28 Sep 2021 17:48:53 -0700 [thread overview]
Message-ID: <20210928174853.06fe8e66@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210928194727.1635106-1-cpp.code.lv@gmail.com>
On Tue, 28 Sep 2021 12:47:27 -0700 Toms Atteka wrote:
> diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
> index a87b44cd5590..dc6eb5f6399f 100644
> --- a/include/uapi/linux/openvswitch.h
> +++ b/include/uapi/linux/openvswitch.h
> @@ -346,6 +346,13 @@ enum ovs_key_attr {
> #ifdef __KERNEL__
> OVS_KEY_ATTR_TUNNEL_INFO, /* struct ip_tunnel_info */
> #endif
> +
> +#ifndef __KERNEL__
#else
> + PADDING, /* Padding so kernel and non kernel field count would match */
The name PADDING seems rather risky, collisions will be likely.
OVS_KEY_ATTR_PADDING maybe?
But maybe we don't need to define this special value and bake it into
the uAPI, why can't we add something like this to the kernel header
(i.e. include/linux/openvswitch.h):
/* Insert a kernel only KEY_ATTR */
#define OVS_KEY_ATTR_TUNNEL_INFO __OVS_KEY_ATTR_MAX
#undef OVS_KEY_ATTR_MAX
#define OVS_KEY_ATTR_MAX __OVS_KEY_ATTR_MAX
> +#endif
next prev parent reply other threads:[~2021-09-29 0:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 19:47 [PATCH net-next v6] net: openvswitch: IPv6: Add IPv6 extension header support Toms Atteka
2021-09-29 0:48 ` Jakub Kicinski [this message]
2021-09-29 6:19 ` Nicolas Dichtel
2021-09-29 13:19 ` Jakub Kicinski
2021-09-30 16:11 ` Cpp Code
2021-10-01 7:21 ` Nicolas Dichtel
2021-10-01 20:42 ` Cpp Code
2021-10-05 6:41 ` Nicolas Dichtel
2021-10-14 21:12 ` Cpp Code
2021-10-15 13:52 ` [ovs-dev] " Ilya Maximets
2021-09-30 16:12 ` Cpp Code
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928174853.06fe8e66@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=cpp.code.lv@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).