From: Jason Gunthorpe <jgg@ziepe.ca>
To: Hillf Danton <hdanton@sina.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+dc3dfba010d7671e05f5@syzkaller.appspotmail.com>,
dledford@redhat.com, leon@kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
syzkaller-bugs@googlegroups.com,
Aleksandr Nogikh <nogikh@google.com>
Subject: Re: [syzbot] KASAN: use-after-free Read in addr_handler (4)
Date: Wed, 6 Oct 2021 08:41:59 -0300 [thread overview]
Message-ID: <20211006114159.GC2688930@ziepe.ca> (raw)
In-Reply-To: <20211006031800.2066-1-hdanton@sina.com>
On Wed, Oct 06, 2021 at 11:18:00AM +0800, Hillf Danton wrote:
> +++ b/drivers/infiniband/core/addr.c
> @@ -795,6 +795,11 @@ void rdma_addr_cancel(struct rdma_dev_ad
> * guarentees no work is running and none will be started.
> */
> cancel_delayed_work_sync(&found->work);
> + /*
> + * flush is needed if work is queued again while it is running, as
> + * cancel waits nothing.
> + */
> + flush_work(&found->work);
The _sync() above does the same, cancel doesn't return while the work
is running
Jason
prev parent reply other threads:[~2021-10-06 11:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 12:41 [syzbot] KASAN: use-after-free Read in addr_handler (4) syzbot
2021-09-15 19:36 ` Jason Gunthorpe
2021-09-16 7:43 ` Dmitry Vyukov
2021-09-16 13:04 ` Jason Gunthorpe
2021-09-16 14:45 ` Dmitry Vyukov
2021-09-16 14:47 ` Dmitry Vyukov
2021-09-16 14:55 ` Dmitry Vyukov
2021-09-16 15:08 ` Jason Gunthorpe
2021-09-16 15:17 ` Dmitry Vyukov
2021-09-16 16:02 ` Jason Gunthorpe
2021-09-16 16:28 ` Jason Gunthorpe
2021-09-20 8:13 ` Dmitry Vyukov
[not found] ` <20211005032901.1876-1-hdanton@sina.com>
2021-10-05 12:23 ` Jason Gunthorpe
[not found] ` <20211006031800.2066-1-hdanton@sina.com>
2021-10-06 11:41 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006114159.GC2688930@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=dvyukov@google.com \
--cc=hdanton@sina.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nogikh@google.com \
--cc=syzbot+dc3dfba010d7671e05f5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).