Re: [PATCH v4 1/5] HID: nintendo: split switch support into its own file

From: kernel test robot <lkp@intel.com>
To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
	Jiri Kosina <jikos@kernel.org>
Cc: kbuild-all@lists.01.org,
	"Emmanuel Gil Peyrot" <linkmauve@linkmauve.fr>,
	linux-input@vger.kernel.org, "Ash Logan" <ash@heyquark.com>,
	"Jonathan Neuschäfer" <j.ne@posteo.net>,
	"Barnabás Pőcze" <pobrn@protonmail.com>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	linux-kernel@vger.kernel.org,
	"Daniel J . Ogorchock" <djogorchock@gmail.com>
Subject: Re: [PATCH v4 1/5] HID: nintendo: split switch support into its own file
Date: Fri, 22 Oct 2021 16:32:02 +0800	[thread overview]
Message-ID: <202110221635.YGAEMPhV-lkp@intel.com> (raw)
In-Reply-To: <20211019110418.26874-2-linkmauve@linkmauve.fr>

[-- Attachment #1: Type: text/plain, Size: 2389 bytes --]

Hi Emmanuel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hid/for-next]
[cannot apply to jikos-hid/for-next jikos-trivial/for-next v5.15-rc6 next-20211021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Emmanuel-Gil-Peyrot/HID-nintendo-split-switch-support-into-its-own-file/20211019-200531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
config: arm-randconfig-c002-20211019 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ef6cb9d1fa01a825280bca49c84b644b8d08bfa6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Emmanuel-Gil-Peyrot/HID-nintendo-split-switch-support-into-its-own-file/20211019-200531
        git checkout ef6cb9d1fa01a825280bca49c84b644b8d08bfa6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/hid/hid-nintendo.c: In function 'nintendo_hid_event':
   drivers/hid/hid-nintendo.c:19:31: warning: unused variable 'driver' [-Wunused-variable]
      19 |         enum nintendo_driver *driver = hid_get_drvdata(hdev);
         |                               ^~~~~~
   drivers/hid/hid-nintendo.c: In function 'nintendo_hid_probe':
>> drivers/hid/hid-nintendo.c:37:16: warning: 'ret' is used uninitialized [-Wuninitialized]
      37 |         return ret;
         |                ^~~

vim +/ret +37 drivers/hid/hid-nintendo.c

c680902a57658c Daniel J. Ogorchock 2021-09-11  36  
c680902a57658c Daniel J. Ogorchock 2021-09-11 @37  	return ret;
c680902a57658c Daniel J. Ogorchock 2021-09-11  38  }
c680902a57658c Daniel J. Ogorchock 2021-09-11  39  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39019 bytes --]