linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair@alistair23.me>
To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: andreas@kemnade.info, alistair23@gmail.com,
	dmitry.torokhov@gmail.com, linus.walleij@linaro.org,
	robh+dt@kernel.org, rydberg@bitmath.org,
	mylene.josserand@free-electrons.com,
	Alistair Francis <alistair@alistair23.me>
Subject: [PATCH 0/4] Add support for the Cypress cyttsp5
Date: Mon, 25 Oct 2021 21:42:10 +1000	[thread overview]
Message-ID: <20211025114214.44617-1-alistair@alistair23.me> (raw)

This patch series builds on top of [1] and adds support for the cyttsp5
touchscreen controller for the reMarkable 2.

I first tried to add an I2C HID device. Although the cyttsp5 has some HID
looking aspects it is not HID compatible. Just in trying to probe the device
I found:
 - The HID descriptor has extra padding
 - The HID descriptor sets the high bytes of the descriptor length
 - The HID descriptor has extra unrecognised tags
 - The HID reset command doesn't appear to work

I don't think there is a way to use the I2C HID framework with the cyttsp5.
For anyone interested you can see the work here [2]. In that branch though I
can only obtain a HID descriptor, nothing else works without more core
changes.

So instead I rebased the series from [1]. Converted to the new yaml DTS
documentation, added regulator support and fixed a x/y miscalculation bug.

1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/
2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid

Alistair Francis (2):
  ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen
  ARM: dts: imx7d: remarkable2: Enable the cyttsp5

Mylène Josserand (2):
  Input: Add driver for Cypress Generation 5 touchscreen
  Documentation: DT: bindings: input: Add documentation for cyttsp5

 .../input/touchscreen/cypress,cyttsp5.yaml    |   72 ++
 arch/arm/boot/dts/imx7d-remarkable2.dts       |   88 ++
 arch/arm/configs/imx_v6_v7_defconfig          |    1 +
 drivers/input/touchscreen/Kconfig             |   14 +
 drivers/input/touchscreen/Makefile            |    1 +
 drivers/input/touchscreen/cyttsp5.c           | 1129 +++++++++++++++++
 6 files changed, 1305 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,cyttsp5.yaml
 create mode 100644 drivers/input/touchscreen/cyttsp5.c

-- 
2.31.1


             reply	other threads:[~2021-10-25 11:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 11:42 Alistair Francis [this message]
2021-10-25 11:42 ` [PATCH 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2021-10-25 20:10   ` Randy Dunlap
2021-10-27  3:45   ` kernel test robot
2021-10-25 11:42 ` [PATCH 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5 Alistair Francis
2021-10-25 18:16   ` Rob Herring
2021-10-25 23:18   ` Linus Walleij
2021-10-26  7:16     ` Andreas Kemnade
2021-10-27 12:28       ` Alistair Francis
2021-10-31 16:49   ` Andreas Kemnade
2021-10-25 11:42 ` [PATCH 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2021-10-25 11:42 ` [PATCH 4/4] ARM: dts: imx7d: remarkable2: Enable the cyttsp5 Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211025114214.44617-1-alistair@alistair23.me \
    --to=alistair@alistair23.me \
    --cc=alistair23@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mylene.josserand@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).