From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Michael Forney <forney@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Nick Terrell <terrelln@fb.com>, Ingo Molnar <mingo@kernel.org>,
Sedat Dilek <sedat.dilek@gmail.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Cc: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Subject: [PATCH 2/2] kbuild: pass --stream-size --no-content-size to zstd
Date: Sat, 20 Nov 2021 11:53:49 -0500 [thread overview]
Message-ID: <20211120165349.99908-2-alex_y_xu@yahoo.ca> (raw)
In-Reply-To: <20211120165349.99908-1-alex_y_xu@yahoo.ca>
Otherwise, it allocates 2 GB of memory at once. Even though the majority
of this memory is never touched, the default heuristic overcommit
refuses this request if less than 2 GB of RAM+swap is currently
available. This results in "zstd: error 11 : Allocation error : not
enough memory" and the kernel failing to build.
When the size is specified, zstd will reduce the memory request
appropriately. For typical kernel sizes of ~32 MB, the largest mmap
request will be reduced to 512 MB, which will succeed on all but the
smallest devices.
For inputs around this size, --stream-size --no-content-size may
slightly decrease the compressed size, or slightly increase it:
https://github.com/facebook/zstd/issues/2848.
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
---
scripts/Makefile.lib | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index ca901814986a..13d756fbcdc7 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -468,10 +468,10 @@ quiet_cmd_xzmisc = XZMISC $@
# be used because it would require zstd to allocate a 128 MB buffer.
quiet_cmd_zstd = ZSTD $@
- cmd_zstd = { cat $(real-prereqs) | $(ZSTD) -19; $(size_append); } > $@
+ cmd_zstd = { cat $(real-prereqs) | $(ZSTD) --stream-size=$(total_size) --no-content-size -19; $(size_append); } > $@
quiet_cmd_zstd22 = ZSTD22 $@
- cmd_zstd22 = { cat $(real-prereqs) | $(ZSTD) -22 --ultra; $(size_append); } > $@
+ cmd_zstd22 = { cat $(real-prereqs) | $(ZSTD) --stream-size=$(total_size) --no-content-size -22 --ultra; $(size_append); } > $@
# ASM offsets
# ---------------------------------------------------------------------------
--
2.34.0
next prev parent reply other threads:[~2021-11-20 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211120165349.99908-1-alex_y_xu.ref@yahoo.ca>
2021-11-20 16:53 ` [PATCH 1/2] kbuild: use perl instead of shell to get file size Alex Xu (Hello71)
2021-11-20 16:53 ` Alex Xu (Hello71) [this message]
2021-11-22 19:20 ` [PATCH 2/2] kbuild: pass --stream-size --no-content-size to zstd Nick Terrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211120165349.99908-2-alex_y_xu@yahoo.ca \
--to=alex_y_xu@yahoo.ca \
--cc=forney@google.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
--cc=terrelln@fb.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).