From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh+dt@kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings:iio:amplifiers: add ad7293 doc
Date: Sun, 21 Nov 2021 12:36:03 +0000 [thread overview]
Message-ID: <20211121123603.3d683f96@jic23-huawei> (raw)
In-Reply-To: <20211115102340.164547-2-antoniu.miclaus@analog.com>
On Mon, 15 Nov 2021 12:23:40 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add device tree bindings for the AD7293 Power Amplifier.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Hi Antoniu,
A few trivial things inline that I'd missed before.
Jonathan
> ---
> no changes in v3
> .../bindings/iio/amplifiers/adi,ad7293.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
> new file mode 100644
> index 000000000000..9f1b2eb78af3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad7293.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/amplifiers/adi,ad7293.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AD7293 12-Bit Power Amplifier Current Controller with ADC,
> + DACs, Temperature and Current Sensors
> +
> +maintainers:
> + - Antoniu Miclaus <antoniu.miclaus@analog.com>
> +
> +description: |
> + Power Amplifier drain current controller containing functionality
> + for general-purpose monitoring and control of current, voltage,
> + and temperature, integrated into a single chip solution with an
> + SPI-compatible interface.
> +
> + https://www.analog.com/en/products/ad7293.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad7293
> +
> + avdd-supply:
> + description:
> + AVDD voltage regulator.
Not sure these descriptions add anything.
avdd-supply: true
is fine.
> +
> + vdrive-supply:
> + description:
> + VDRIVE voltage regulator.
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + reset-gpios: true
Specify how many?
maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - avdd-supply
> + - vdrive-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + ad7293@0 {
> + compatible = "adi,ad7293";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + avdd-supply = <&avdd>;
> + vdrive-supply = <&vdrive>;
> + reset-gpios = <&gpio 10 0>;
> + };
> + };
> +...
next prev parent reply other threads:[~2021-11-21 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 10:23 [PATCH v3 1/2] iio:amplifiers:ad7293: add support for AD7293 Antoniu Miclaus
2021-11-15 10:23 ` [PATCH v3 2/2] dt-bindings:iio:amplifiers: add ad7293 doc Antoniu Miclaus
2021-11-21 12:36 ` Jonathan Cameron [this message]
2021-11-21 13:39 ` [PATCH v3 1/2] iio:amplifiers:ad7293: add support for AD7293 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211121123603.3d683f96@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).