From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: cgel.zte@gmail.com, mathew.j.martineau@linux.intel.com,
davem@davemloft.net, shuah@kernel.org, netdev@vger.kernel.org,
mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Ye Guojin <ye.guojin@zte.com.cn>,
ZealRobot <zealci@zte.com.cn>
Subject: Re: [PATCH] selftests: mptcp: remove duplicate include in mptcp_inq.c
Date: Fri, 10 Dec 2021 06:56:44 -0800 [thread overview]
Message-ID: <20211210065644.192f5159@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211210065437.27c8fe23@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 10 Dec 2021 06:54:37 -0800 Jakub Kicinski wrote:
> On Fri, 10 Dec 2021 10:58:27 +0100 Matthieu Baerts wrote:
> > Hi Ye,
> >
> > On 10/12/2021 08:14, cgel.zte@gmail.com wrote:
> > > From: Ye Guojin <ye.guojin@zte.com.cn>
> > >
> > > 'sys/ioctl.h' included in 'mptcp_inq.c' is duplicated.
> >
> > Good catch, the modification looks good to me:
> >
> > Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> >
> >
> > This patch is for "net-next" tree as it fixes an issue introduced by a
> > patch only in this tree:
> >
> > Fixes: b51880568f20 ("selftests: mptcp: add inq test case")
> >
> > Regarding the commit message, please next time include the Fixes tag and
> > mention for which tree it is for in the FAQ [1], e.g. [PATCH net-next].
> >
> >
> > @David/Jakub: do you prefer a v2 with these modifications or is it fine
> > to apply this small patch directly in net-next tree?
>
> v1 is fine. Let me apply it right away and do the edits before I forget
> they are needed..
Actually, I take that back, let's hear from Mat, he may want to take
the patch via his tree.
next prev parent reply other threads:[~2021-12-10 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 7:14 [PATCH] selftests: mptcp: remove duplicate include in mptcp_inq.c cgel.zte
2021-12-10 9:58 ` Matthieu Baerts
2021-12-10 14:54 ` Jakub Kicinski
2021-12-10 14:56 ` Jakub Kicinski [this message]
2021-12-10 15:36 ` Matthieu Baerts
2021-12-10 15:57 ` Jakub Kicinski
2021-12-10 18:00 ` Mat Martineau
2021-12-10 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210065644.192f5159@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=ye.guojin@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).