From: kernel test robot <lkp@intel.com>
To: Wander Lairson Costa <wander@redhat.com>, linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-rt-users@vger.kernel.org,
Wander Lairson Costa <wander@redhat.com>
Subject: Re: [PREEMPT_RT PATCH 1/2] block: Avoid sleeping function called from invalid context bug
Date: Sat, 11 Dec 2021 13:21:08 +0800 [thread overview]
Message-ID: <202112111300.2jYSEVK1-lkp@intel.com> (raw)
In-Reply-To: <20211210204156.96336-2-wander@redhat.com>
Hi Wander,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linux/master linus/master v5.16-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Wander-Lairson-Costa/Fix-warnings-in-blktrace/20211211-044405
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-randconfig-a016-20211210 (https://download.01.org/0day-ci/archive/20211211/202112111300.2jYSEVK1-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/37b10b13961fb1af60139789717a018f788f714e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Wander-Lairson-Costa/Fix-warnings-in-blktrace/20211211-044405
git checkout 37b10b13961fb1af60139789717a018f788f714e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> block/blk-cgroup.c:1915:8: error: implicit declaration of function 'get_cpu_light' [-Werror,-Wimplicit-function-declaration]
cpu = get_cpu_light();
^
>> block/blk-cgroup.c:1932:2: error: implicit declaration of function 'put_cpu_light' [-Werror,-Wimplicit-function-declaration]
put_cpu_light();
^
block/blk-cgroup.c:1932:2: note: did you mean 'get_cpu_light'?
block/blk-cgroup.c:1915:8: note: 'get_cpu_light' declared here
cpu = get_cpu_light();
^
2 errors generated.
vim +/get_cpu_light +1915 block/blk-cgroup.c
1908
1909 void blk_cgroup_bio_start(struct bio *bio)
1910 {
1911 int rwd = blk_cgroup_io_type(bio), cpu;
1912 struct blkg_iostat_set *bis;
1913 unsigned long flags;
1914
> 1915 cpu = get_cpu_light();
1916 bis = per_cpu_ptr(bio->bi_blkg->iostat_cpu, cpu);
1917 flags = u64_stats_update_begin_irqsave(&bis->sync);
1918
1919 /*
1920 * If the bio is flagged with BIO_CGROUP_ACCT it means this is a split
1921 * bio and we would have already accounted for the size of the bio.
1922 */
1923 if (!bio_flagged(bio, BIO_CGROUP_ACCT)) {
1924 bio_set_flag(bio, BIO_CGROUP_ACCT);
1925 bis->cur.bytes[rwd] += bio->bi_iter.bi_size;
1926 }
1927 bis->cur.ios[rwd]++;
1928
1929 u64_stats_update_end_irqrestore(&bis->sync, flags);
1930 if (cgroup_subsys_on_dfl(io_cgrp_subsys))
1931 cgroup_rstat_updated(bio->bi_blkg->blkcg->css.cgroup, cpu);
> 1932 put_cpu_light();
1933 }
1934
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-12-11 5:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 20:41 [PREEMPT_RT PATCH 0/2] Fix warnings in blktrace Wander Lairson Costa
2021-12-10 20:41 ` [PREEMPT_RT PATCH 1/2] block: Avoid sleeping function called from invalid context bug Wander Lairson Costa
2021-12-11 5:21 ` kernel test robot [this message]
2021-12-10 20:41 ` [PREEMPT_RT PATCH 2/2] blktrace: switch trace spinlock to a raw spinlock Wander Lairson Costa
2021-12-11 3:06 ` kernel test robot
2021-12-11 10:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112111300.2jYSEVK1-lkp@intel.com \
--to=lkp@intel.com \
--cc=bigeasy@linutronix.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).