linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Weiss <luca.weiss@fairphone.com>
To: linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org,
	Luca Weiss <luca.weiss@fairphone.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 10/10] arm64: dts: qcom: sm6350: Fix validation errors
Date: Mon, 13 Dec 2021 09:26:11 +0100	[thread overview]
Message-ID: <20211213082614.22651-11-luca.weiss@fairphone.com> (raw)
In-Reply-To: <20211213082614.22651-1-luca.weiss@fairphone.com>

Sort clocks and interrupts as specified in the docs and remove the stray
property #power-domain-cells from aoss_qmp to solve dtbs_check
validation errors.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/sm6350.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index a7158fe9e192..8322a981cdfc 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -810,10 +810,10 @@ usb_1_qmpphy: phy@88e9000 {
 			ranges;
 
 			clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>,
+				 <&xo_board>,
 				 <&rpmhcc RPMH_QLINK_CLK>,
-				 <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>,
-				 <&xo_board>;
-			clock-names = "aux", "ref", "com_aux", "cfg_ahb";
+				 <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>;
+			clock-names = "aux", "cfg_ahb", "ref", "com_aux";
 
 			resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
 				 <&gcc GCC_USB3_PHY_PRIM_BCR>;
@@ -871,11 +871,12 @@ usb_1: usb@a6f8800 {
 				      "sleep";
 
 			interrupts-extended = <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
-					      <&pdc 14 IRQ_TYPE_EDGE_BOTH>,
+					      <&pdc 17 IRQ_TYPE_LEVEL_HIGH>,
 					      <&pdc 15 IRQ_TYPE_EDGE_BOTH>,
-					      <&pdc 17 IRQ_TYPE_LEVEL_HIGH>;
-			interrupt-names = "hs_phy_irq", "dp_hs_phy_irq",
-					  "dm_hs_phy_irq", "ss_phy_irq";
+					      <&pdc 14 IRQ_TYPE_EDGE_BOTH>;
+
+			interrupt-names = "hs_phy_irq", "ss_phy_irq",
+					  "dm_hs_phy_irq", "dp_hs_phy_irq";
 
 			power-domains = <&gcc USB30_PRIM_GDSC>;
 
@@ -935,7 +936,6 @@ aoss_qmp: power-controller@c300000 {
 			mboxes = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP>;
 
 			#clock-cells = <0>;
-			#power-domain-cells = <1>;
 		};
 
 		spmi_bus: spmi@c440000 {
-- 
2.34.1


  parent reply	other threads:[~2021-12-13  8:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  8:26 [PATCH 00/10] dt-binding patches for sm6350 Luca Weiss
2021-12-13  8:26 ` [PATCH 01/10] dt-bindings: arm: msm: Add LLCC for SM6350 Luca Weiss
2021-12-13  8:26 ` [PATCH 02/10] dt-bindings: firmware: scm: Add SM6350 compatible Luca Weiss
2021-12-15 20:09   ` Rob Herring
2021-12-13  8:26 ` [PATCH 03/10] dt-bindings: qcom,pdc: " Luca Weiss
2021-12-15 20:10   ` Rob Herring
2022-04-08 11:24     ` Luca Weiss
2022-04-08 14:28       ` Rob Herring
2021-12-13  8:26 ` [PATCH 04/10] dt-bindings: phy: qcom,qusb2: " Luca Weiss
2021-12-14  7:38   ` Vinod Koul
2021-12-13  8:26 ` [PATCH 05/10] dt-bindings: thermal: tsens: " Luca Weiss
2021-12-15 20:10   ` Rob Herring
2022-04-08 11:25     ` Luca Weiss
2022-04-08 14:28       ` Rob Herring
2022-04-08 14:44         ` Daniel Lezcano
2021-12-13  8:26 ` [PATCH 06/10] dt-bindings: usb: qcom,dwc3: " Luca Weiss
2021-12-15 20:10   ` Rob Herring
2021-12-13  8:26 ` [PATCH 07/10] dt-bindings: watchdog: Add SM6350 and SM8250 compatible Luca Weiss
2021-12-15 20:10   ` Rob Herring
2021-12-13  8:26 ` [PATCH 08/10] dt-bindings: arm: msm: Don't mark LLCC interrupt as required Luca Weiss
2021-12-15 20:11   ` Rob Herring
2021-12-13  8:26 ` [PATCH 09/10] dt-bindings: simple-framebuffer: allow standalone compatible Luca Weiss
2021-12-15 20:11   ` Rob Herring
2021-12-13  8:26 ` Luca Weiss [this message]
2021-12-15 22:27 ` (subset) [PATCH 00/10] dt-binding patches for sm6350 Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213082614.22651-11-luca.weiss@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).