From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kees Cook <keescook@chromium.org>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Arnaud Ebalard <arno@natisbad.org>,
Srujana Challa <schalla@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Suheil Chandran <schandran@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
Lukasz Bartosik <lbartosik@marvell.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] crypto: octeontx2 - Avoid stack variable overflow
Date: Fri, 17 Dec 2021 15:51:50 +1100 [thread overview]
Message-ID: <20211217045150.GA20345@gondor.apana.org.au> (raw)
In-Reply-To: <20211215225558.1995027-1-keescook@chromium.org>
On Wed, Dec 15, 2021 at 02:55:58PM -0800, Kees Cook wrote:
>> @@ -1762,7 +1762,7 @@ void otx2_cpt_print_uc_dbg_info(struct otx2_cptpf_dev *cptpf)
> char engs_info[2 * OTX2_CPT_NAME_LENGTH];
> struct otx2_cpt_eng_grp_info *grp;
> struct otx2_cpt_engs_rsvd *engs;
> - u32 mask[4];
> + u32 mask[5];
Are you sure 144 bits will overflow u32[4]? If not then shouldn't
the fix be to remove the bogus print on mask[4]?
On another note, the debug code looks like crap if engs_num is
less than the maximum of 144 as it will print random data from
the kernel stack.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-12-17 4:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 22:55 [PATCH] crypto: octeontx2 - Avoid stack variable overflow Kees Cook
2021-12-17 4:51 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217045150.GA20345@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arno@natisbad.org \
--cc=bbrezillon@kernel.org \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=lbartosik@marvell.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schalla@marvell.com \
--cc=schandran@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).