From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A277C433F5 for ; Fri, 11 Feb 2022 16:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351651AbiBKQoJ (ORCPT ); Fri, 11 Feb 2022 11:44:09 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234654AbiBKQoG (ORCPT ); Fri, 11 Feb 2022 11:44:06 -0500 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE955102; Fri, 11 Feb 2022 08:44:05 -0800 (PST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id A17F12B0013A; Fri, 11 Feb 2022 11:44:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 11 Feb 2022 11:44:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=ufGFnpr7sURnSIynd9rsTHgA0vYHEgxxVeCjWO TqPFE=; b=DPLFx3pt0hR902PHT4xjUPd2AsKbnV2Plr2ZZhMFmL8rsJohPxWjO+ OLnQrI+QFzlEeOa4b7NXnFWofkh+4tLxK3CJF9+AUk7bEUW4hQj6clVovOP6ECk1 CgVuYFGvuEhQO22C2ImalqqOxJ3QLNe3yRQ9pirmVVeesXW2oV3I6y2eTDeKPQG1 z4j6TTvFC0wTbkVFkM06LT9GQfmtCST1v4q5W9iMRu1YCxs2GXCqJEnAClxQavL7 HhP2G7WBKvHYx+2QGOBHP9t+Oquiv7U9zDVpXCOrQHmOTm8LhFEXVii3yFSNeNlT c6gjePfuzfRRGKgQUglB0q31CB7dkHiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ufGFnpr7sURnSIynd 9rsTHgA0vYHEgxxVeCjWOTqPFE=; b=dTNlyGMFEs90slxYGRRhPUr43pbBHp161 /zAifbSRLtO9AEGMtH+go+SL3ey/MRHEn+sdrwy2naxaneReAXqQ7J03Tl1nZuwX GLHRgIG5AQQOJR19+4/2kk2f8fML6CoCUi30EGj2ZtWMzh4IqEAwH0eSYfTOoi0q coq8P9jeF1yp7Te0dALiSoib6BVMpZSvpuPMs+gbWNZ7Gbv/i3dl2vtOhx0SheCg RevV/vyMULSA1r4CI0nMq/AE1NnsrSnpnE9LpG1znBmBcXsr3PVpV+zXEJxJq2Kc HLjnrP7quO/o5nj4SLuNUCCFd98NurK5kPHAUVVH+qP6lNYrUnSWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieefgdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Feb 2022 11:44:02 -0500 (EST) Date: Fri, 11 Feb 2022 17:44:00 +0100 From: Maxime Ripard To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Sakari Ailus , Hans Verkuil , Chen-Yu Tsai , Jernej Skrabec , Greg Kroah-Hartman , Helen Koike , Laurent Pinchart , Thomas Petazzoni Subject: Re: [PATCH v2 30/66] media: sun6i-csi: Add bridge v4l2 subdev with port management Message-ID: <20220211164400.ccp4j2puryhurvzd@houat> References: <20220205185429.2278860-1-paul.kocialkowski@bootlin.com> <20220205185429.2278860-31-paul.kocialkowski@bootlin.com> <20220209092419.i3kver4f2am7mnow@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xqbsdqvt6owp5vdi" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xqbsdqvt6owp5vdi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 11, 2022 at 04:43:51PM +0100, Paul Kocialkowski wrote: > Hi, >=20 > On Wed 09 Feb 22, 10:24, Maxime Ripard wrote: > > On Sat, Feb 05, 2022 at 07:53:53PM +0100, Paul Kocialkowski wrote: > > > Introduce a bridge v4l2 subdev to prepare for separation between the > > > processing part (bridge) and the dma engine, which is required to > > > properly support ths isp workflow later on. > > >=20 > > > Currently the bridge just manages fwnode mapping to media pads, > > > using an async notifier (which was previously in the main code). > > > The s_stream video op just forwards to the connected v4l2 subdev > > > (sensor or MIPI CSI-2 bridge). > > >=20 > > > The video capture device is now registered after the bridge and > > > attaches to it with a media link. > > >=20 > > > Signed-off-by: Paul Kocialkowski > >=20 > > There's a bunch of checkpatch --strict warnings that need to be fixed >=20 > Yes so it turns out these are adaptations to the existing video code > which has these warnings already merged. They are cleaned up later on > in a dedicated commit, but since it's not the topic of this change > (which is a logic change) I kept the code as it is. >=20 > What do you think? + async_subdev =3D v4l2_async_nf_add_fwnode_remote(notifier, handle, + struct v4l2_async_subdev); CHECK: Alignment should match open parenthesis This one at least is introduced by your patch Maxime --xqbsdqvt6owp5vdi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYgaSUAAKCRDj7w1vZxhR xXGWAP0VX30FCSaxEfCylC0wvIQbV1OfNYW4aaL8aT/WKEZPGgEAtehwn0huoPF7 uno2SSUQZBowBDAPo9fxBKol2O9KAwQ= =0iKA -----END PGP SIGNATURE----- --xqbsdqvt6owp5vdi--