From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
platform-driver-x86@vger.kernel.org, x86@kernel.org
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
"Pali Rohár" <pali@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Mark Gross" <markgross@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Randy Dunlap" <rdunlap@infradead.org>
Subject: [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description
Date: Sat, 12 Feb 2022 13:56:54 +0100 [thread overview]
Message-ID: <20220212125654.357408-2-mat.jonczyk@o2.pl> (raw)
In-Reply-To: <20220212125654.357408-1-mat.jonczyk@o2.pl>
It is not the laptops, but the /proc/i8k interface that is legacy (or so
I think was the intention of the help text author). The old description
was confusing, fix this.
The phrase "Say Y if you intend to run this kernel on old Dell laptops
or want to use userspace package i8kutils." was introduced in 2015, in
commit 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
I think that "old laptops" was about hotkey and Fn key support - this
driver in the 2.4 kernels' era apparently had these capabilities
(see: https://github.com/vitorafsr/i8kutils , description of
"repeat_rate" kernel module parameter).
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Pali Rohár <pali@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Mark Gross <markgross@kernel.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
---
v2:
- help text language fixes (thanks: Randy Dunlap),
- modify commit description.
---
drivers/hwmon/Kconfig | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 1ee4e5eff567..39aeecc72800 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -506,19 +506,18 @@ config SENSORS_DELL_SMM
userspace interface for i8kutils package.
config I8K
- bool "Dell i8k legacy laptop support"
+ bool "Legacy /proc/i8k interface of Dell laptop SMM BIOS hwmon driver"
depends on SENSORS_DELL_SMM
depends on PROC_FS
help
- This option enables legacy /proc/i8k userspace interface in hwmon
- dell-smm-hwmon driver. Character file /proc/i8k reports bios version,
- temperature and allows controlling fan speeds of Dell laptops via
- System Management Mode. For old Dell laptops (like Dell Inspiron 8000)
- it reports also power and hotkey status. For fan speed control is
- needed userspace package i8kutils.
+ This option enables the legacy /proc/i8k userspace interface of the
+ dell-smm-hwmon driver. The character file /proc/i8k exposes the BIOS
+ version, temperatures and allows control of fan speeds of some Dell
+ laptops. Sometimes it also reports power and hotkey status.
- Say Y if you intend to run this kernel on old Dell laptops or want to
- use userspace package i8kutils.
+ This interface is required to run programs from the i8kutils package.
+
+ Say Y if you intend to run userspace programs that use this interface.
Say N otherwise.
config SENSORS_DA9052_ADC
--
2.25.1
next prev parent reply other threads:[~2022-02-12 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 12:56 [PATCH 1/2] x86/Kconfig: move and modify CONFIG_I8K Mateusz Jończyk
2022-02-12 12:56 ` Mateusz Jończyk [this message]
2022-02-13 15:28 ` [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description Guenter Roeck
2022-02-13 15:25 ` [PATCH 1/2] x86/Kconfig: move and modify CONFIG_I8K Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2022-02-07 18:29 Mateusz Jończyk
2022-02-07 18:29 ` [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description Mateusz Jończyk
2022-02-07 18:47 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220212125654.357408-2-mat.jonczyk@o2.pl \
--to=mat.jonczyk@o2.pl \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).