From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: alexandre.belloni@bootlin.com, festevam@gmail.com,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
richard.genoud@gmail.com, gregkh@linuxfoundation.org,
s.hauer@pengutronix.de, linux@armlinux.org.uk,
nicolas.ferre@microchip.com, alexandre.torgue@foss.st.com,
ludovic.desroches@microchip.com, lukas@wunner.de,
linux-imx@nxp.com, mcoquelin.stm32@gmail.com,
linux-serial@vger.kernel.org, shawnguo@kernel.org,
jirislaby@kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/9] serial: core: move RS485 configuration tasks from drivers into core
Date: Mon, 14 Feb 2022 19:23:11 +0100 [thread overview]
Message-ID: <20220214182311.xaxkdgw5x66vubvv@pengutronix.de> (raw)
In-Reply-To: <edbb9e1d-bed4-0850-08f4-029c4fcbfd5c@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
Hello Lino,
On Mon, Feb 14, 2022 at 04:09:53PM +0100, Lino Sanfilippo wrote:
> On 14.02.22 at 08:06, Uwe Kleine-König wrote:
> > I was only Cc:d for the imx patch (patch #7) and tried to verify the
> > claim there that "the serial core already assigns the passed
> > configuration to the uart port". That failed when I looked at my kernel
> > tree.
> >
> > So it would be great, if you sent dependencies (or at least a cover
> > letter) to all recipients of a given patch to ease review. Also I want
> > to suggest to mention uart_set_rs485_config() in the commit log of the
> > imx patch (and probably the others) to simplify verifying the claim
> > there.
>
> Thanks for the review, I will correct the typos in the next version.
> I will also cc you directly for the next version if you dont mind.
I don't mind. I get so many patches by mail, I'm good at ignoring them
;-)
> get_maintainers only spit out "Pengutronix Kernel Team" so I used that
> address for the whole series (including the cover letter).
That's why I eventually found the whole series and could reply to patch
#1.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-14 18:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 22:27 Move RS485 implementation from drivers to serial core Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 1/9] serial: core: move RS485 configuration tasks from drivers into core Lino Sanfilippo
2022-02-14 5:41 ` Jiri Slaby
2022-02-14 16:13 ` Lino Sanfilippo
2022-02-14 7:06 ` Uwe Kleine-König
2022-02-14 15:09 ` Lino Sanfilippo
2022-02-14 18:23 ` Uwe Kleine-König [this message]
2022-02-13 22:27 ` [PATCH 2/9] serial: amba-pl011: remove redundant code in rs485_config Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 3/9] serial: stm32: " Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 4/9] serial: sc16is7xx: " Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 5/9] serial: omap: " Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 6/9] serial: max310: " Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 7/9] serial: imx: remove redundant assignment " Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 8/9] serial: fsl_lpuart: remove redundant code in rs485_config functions Lino Sanfilippo
2022-02-13 22:27 ` [PATCH 9/9] serial: atmel: remove redundant assignment in rs485_config Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214182311.xaxkdgw5x66vubvv@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=LinoSanfilippo@gmx.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=ludovic.desroches@microchip.com \
--cc=lukas@wunner.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=richard.genoud@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).