Re: [PATCH v1] power: supply: add dock type

[Sebastian Reichel <sebastian.reichel@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 3082 bytes --]

Hi,

When you send a new patch version you should

a) increase patch version (this is v2)
b) add a changelog below the --- marker

Apart from that this submission is still missing a
driver using the newly introduced POWER_SUPPLY_TYPE_DOCK.
Mainline kernel ABI is only extended for mainline kernel
users.

Thanks,

-- Sebastian

On Mon, Feb 14, 2022 at 02:22:52PM +0800, Jack Wu wrote:
> + Ken
> 
> Jack Wu <wjack@google.com> 於 2022年1月7日 週五 上午11:37寫道：
> >
> > + Alex and Vincent
> >
> > Jack Wu <wjack@google.com> 於 2022年1月4日 週二 下午8:25寫道：
> > >
> > > Add dock power_supply_type for the drivers which supports dock can
> > > register a power supply class device with POWER_SUPPLY_TYPE_DOCK.
> > >
> > > Signed-off-by: Jack Wu <wjack@google.com>
> > > ---
> > >  Documentation/ABI/testing/sysfs-class-power | 2 +-
> > >  drivers/power/supply/power_supply_sysfs.c   | 1 +
> > >  include/linux/power_supply.h                | 1 +
> > >  3 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > > index f7904efc4cfa..854299a0d36f 100644
> > > --- a/Documentation/ABI/testing/sysfs-class-power
> > > +++ b/Documentation/ABI/testing/sysfs-class-power
> > > @@ -34,7 +34,7 @@ Description:
> > >                 Describes the main type of the supply.
> > >
> > >                 Access: Read
> > > -               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless"
> > > +               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless", "Dock"
> > >
> > >  **Battery and USB properties**
> > >
> > > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> > > index c3d7cbcd4fad..53494b56bbb4 100644
> > > --- a/drivers/power/supply/power_supply_sysfs.c
> > > +++ b/drivers/power/supply/power_supply_sysfs.c
> > > @@ -57,6 +57,7 @@ static const char * const POWER_SUPPLY_TYPE_TEXT[] = {
> > >         [POWER_SUPPLY_TYPE_USB_PD_DRP]          = "USB_PD_DRP",
> > >         [POWER_SUPPLY_TYPE_APPLE_BRICK_ID]      = "BrickID",
> > >         [POWER_SUPPLY_TYPE_WIRELESS]            = "Wireless",
> > > +       [POWER_SUPPLY_TYPE_DOCK]                = "Dock",
> > >  };
> > >
> > >  static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {
> > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> > > index 9ca1f120a211..fa80eaa54242 100644
> > > --- a/include/linux/power_supply.h
> > > +++ b/include/linux/power_supply.h
> > > @@ -187,6 +187,7 @@ enum power_supply_type {
> > >         POWER_SUPPLY_TYPE_USB_PD_DRP,           /* PD Dual Role Port */
> > >         POWER_SUPPLY_TYPE_APPLE_BRICK_ID,       /* Apple Charging Method */
> > >         POWER_SUPPLY_TYPE_WIRELESS,             /* Wireless */
> > > +       POWER_SUPPLY_TYPE_DOCK,                 /* Dock Charging */
> > >  };
> > >
> > >  enum power_supply_usb_type {
> > > --
> > > 2.34.1.448.ga2b2bfdf31-goog
> > >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]