From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
"Matthias Kaehlcke" <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
<linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_ppratap@quicinc.com>
Subject: Re: [PATCH v11 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status
Date: Tue, 22 Mar 2022 14:07:38 +0530 [thread overview]
Message-ID: <20220322083738.GM23316@hu-pkondeti-hyd.qualcomm.com> (raw)
In-Reply-To: <1647932876-23249-6-git-send-email-quic_c_sanm@quicinc.com>
Hi Sandeep,
On Tue, Mar 22, 2022 at 12:37:56PM +0530, Sandeep Maheswaram wrote:
> Keep the power domain on in order to retail controller status and
> to support wakeup from devices.
>
%s/retail/retain
retain the controller status so that remote wakeup / device connect /
device disconnect events can be detected during suspend.
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 9804a19..35087cf 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -17,6 +17,7 @@
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/phy/phy.h>
> +#include <linux/pm_domain.h>
> #include <linux/usb/of.h>
> #include <linux/reset.h>
> #include <linux/iopoll.h>
> @@ -724,6 +725,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
> struct resource *res, *parent_res = NULL;
> int ret, i;
> bool ignore_pipe_clk;
> + struct generic_pm_domain *genpd;
>
> qcom = devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL);
> if (!qcom)
> @@ -732,6 +734,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, qcom);
> qcom->dev = &pdev->dev;
>
> + genpd = pd_to_genpd(qcom->dev->pm_domain);
> +
> if (has_acpi_companion(dev)) {
> qcom->acpi_pdata = acpi_device_get_match_data(dev);
> if (!qcom->acpi_pdata) {
> @@ -839,6 +843,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
> if (ret)
> goto interconnect_exit;
>
> + genpd->flags |= GENPD_FLAG_ALWAYS_ON;
> +
> device_init_wakeup(&pdev->dev, 1);
> qcom->is_suspended = false;
> pm_runtime_set_active(dev);
> --
> 2.7.4
>
Thanks,
Pavan
next prev parent reply other threads:[~2022-03-22 8:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 7:07 [PATCH v11 0/5] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2022-03-22 7:07 ` [PATCH v11 1/5] usb: dwc3: core: Add HS phy mode variable and phy poweroff flag Sandeep Maheswaram
2022-03-22 8:09 ` Pavan Kondeti
2022-03-22 8:42 ` Sandeep Maheswaram (Temp)
2022-03-22 7:07 ` [PATCH v11 2/5] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2022-03-22 8:32 ` Pavan Kondeti
2022-03-22 8:40 ` Pavan Kondeti
2022-04-05 9:25 ` Pavan Kondeti
2022-03-23 18:07 ` Matthias Kaehlcke
2022-03-24 4:54 ` Sandeep Maheswaram (Temp)
2022-03-30 4:03 ` Pavan Kondeti
2022-03-30 16:46 ` Matthias Kaehlcke
2022-03-31 3:14 ` Pavan Kondeti
2022-03-22 7:07 ` [PATCH v11 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2022-03-22 8:33 ` Pavan Kondeti
2022-03-22 7:07 ` [PATCH v11 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend Sandeep Maheswaram
2022-03-22 8:36 ` Pavan Kondeti
2022-03-22 7:07 ` [PATCH v11 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status Sandeep Maheswaram
2022-03-22 8:37 ` Pavan Kondeti [this message]
2022-03-22 9:18 ` Sandeep Maheswaram (Temp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322083738.GM23316@hu-pkondeti-hyd.qualcomm.com \
--to=quic_pkondeti@quicinc.com \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).