From: Jiri Slaby <jslaby@suse.cz>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH 07/11] serial: pic32: convert to_pic32_sport() to an inline
Date: Tue, 3 May 2022 08:31:18 +0200 [thread overview]
Message-ID: <20220503063122.20957-8-jslaby@suse.cz> (raw)
In-Reply-To: <20220503063122.20957-1-jslaby@suse.cz>
'c' is not in wrapped in parentheses in the to_pic32_sport() macro, so
it might be problematic wrt macro expansion. Using an inline is always
safer in these cases. Both type-wise and macro-expansion-wise. So switch
the macro to an inline.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/tty/serial/pic32_uart.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
index 32a86b12f203..c3b4fd0b5b76 100644
--- a/drivers/tty/serial/pic32_uart.c
+++ b/drivers/tty/serial/pic32_uart.c
@@ -72,7 +72,11 @@ struct pic32_sport {
struct device *dev;
};
-#define to_pic32_sport(c) container_of(c, struct pic32_sport, port)
+
+static inline struct pic32_sport *to_pic32_sport(struct uart_port *port)
+{
+ return container_of(port, struct pic32_sport, port);
+}
static inline void pic32_uart_writel(struct pic32_sport *sport,
u32 reg, u32 val)
--
2.36.0
next prev parent reply other threads:[~2022-05-03 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 6:31 [PATCH 00/11] serial: pic32: cleanup Jiri Slaby
2022-05-03 6:31 ` [PATCH 01/11] serial: pic32: remove unused items from the header Jiri Slaby
2022-05-03 6:31 ` [PATCH 02/11] serial: pic32: move header content to .c Jiri Slaby
2022-05-03 6:31 ` [PATCH 03/11] serial: pic32: remove constants from struct pic32_sport Jiri Slaby
2022-05-03 6:31 ` [PATCH 04/11] serial: pic32: simplify clk handling Jiri Slaby
2022-05-03 6:31 ` [PATCH 05/11] serial: pic32: simplify pic32_sport::enable_tx_irq handling Jiri Slaby
2022-05-03 6:31 ` [PATCH 06/11] serial: pic32: remove pic32_get_port() macro Jiri Slaby
2022-05-03 6:31 ` Jiri Slaby [this message]
2022-05-03 6:31 ` [PATCH 08/11] serial: pic32: don't assign pic32_sport::cts_gpio twice Jiri Slaby
2022-05-03 6:31 ` [PATCH 09/11] serial: pic32: don't zero members of kzalloc-ated structure Jiri Slaby
2022-05-03 6:31 ` [PATCH 10/11] serial: pic32: free up irq names correctly Jiri Slaby
2022-05-03 6:31 ` [PATCH 11/11] serial: pic32: restore disabled irqs in pic32_uart_startup() Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503063122.20957-8-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).