From: Stephen Boyd <sboyd@kernel.org>
To: Len Baker <len.baker@gmx.com>,
Michael Turquette <mturquette@baylibre.com>,
Tero Kristo <kristo@kernel.org>
Cc: Len Baker <len.baker@gmx.com>, Kees Cook <keescook@chromium.org>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: ti: composite: Prefer kcalloc over open coded arithmetic
Date: Fri, 20 May 2022 20:40:23 -0700 [thread overview]
Message-ID: <20220521034025.5909FC385A9@smtp.kernel.org> (raw)
In-Reply-To: <20210904131714.2312-1-len.baker@gmx.com>
Quoting Len Baker (2021-09-04 06:17:14)
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, use the purpose specific kcalloc() function instead of the argument
> size * count in the kzalloc() function.
>
> [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
>
> Signed-off-by: Len Baker <len.baker@gmx.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2022-05-21 3:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 13:17 [PATCH] clk: ti: composite: Prefer kcalloc over open coded arithmetic Len Baker
2022-05-21 3:40 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220521034025.5909FC385A9@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=keescook@chromium.org \
--cc=kristo@kernel.org \
--cc=len.baker@gmx.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).