linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [RFT PATCH v2 05/14] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO
Date: Wed, 17 Aug 2022 16:03:33 +0300	[thread overview]
Message-ID: <20220817130342.568396-6-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org>

The TCSR mutex bindings allow device to be described only with address
space (so it uses MMIO, not syscon regmap).  This seems reasonable as
TCSR mutex is actually a dedicated IO address space and it also fixes DT
schema checks:

  qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'reg' is a required property
  qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index f0806ed103f1..22b2da74d105 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -308,12 +308,6 @@ scm {
 		};
 	};
 
-	tcsr_mutex: hwlock {
-		compatible = "qcom,tcsr-mutex";
-		syscon = <&tcsr_mutex_regs 0 0x1000>;
-		#hwlock-cells = <1>;
-	};
-
 	psci {
 		compatible = "arm,psci-1.0";
 		method = "smc";
@@ -1047,9 +1041,10 @@ ufsphy_lanes: phy@1da7400 {
 			};
 		};
 
-		tcsr_mutex_regs: syscon@1f40000 {
-			compatible = "syscon";
+		tcsr_mutex: hwlock@1f40000 {
+			compatible = "qcom,tcsr-mutex";
 			reg = <0x01f40000 0x20000>;
+			#hwlock-cells = <1>;
 		};
 
 		tcsr_regs_1: sycon@1f60000 {
-- 
2.34.1


  parent reply	other threads:[~2022-08-17 13:04 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 13:03 [RFT PATCH v2 00/14] arm64: dts: qcom: improvements to TCSR mutex in DTS Krzysztof Kozlowski
2022-08-17 13:03 ` [RFT PATCH v2 01/14] dt-bindings: mfd: qcom,tcsr: add SC7x80, SDM845 and MSM8996/8 Krzysztof Kozlowski
2022-09-08  8:09   ` Lee Jones
2022-08-17 13:03 ` [RFT PATCH v2 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 20:57   ` Konrad Dybcio
2022-08-18  7:02     ` Krzysztof Kozlowski
2022-08-18 12:00       ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 03/14] arm64: dts: qcom: msm8996: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 20:59   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 04/14] arm64: dts: qcom: msm8998: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 21:00   ` Konrad Dybcio
2022-08-17 13:03 ` Krzysztof Kozlowski [this message]
2022-08-17 21:01   ` [RFT PATCH v2 05/14] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 06/14] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible Krzysztof Kozlowski
2022-08-17 21:01   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 07/14] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 21:02   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 08/14] arm64: dts: qcom: sc7180: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 21:02   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 09/14] arm64: dts: qcom: sc7280: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 21:03   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 10/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-08-17 21:03   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 11/14] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 21:04   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 12/14] arm64: dts: qcom: qcs404: " Krzysztof Kozlowski
2022-08-17 21:04   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 13/14] arm64: dts: qcom: sdm630: " Krzysztof Kozlowski
2022-08-17 21:06   ` Konrad Dybcio
2022-08-17 13:03 ` [RFT PATCH v2 14/14] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2022-08-17 21:07   ` Konrad Dybcio
2022-08-18  7:04     ` Krzysztof Kozlowski
2022-08-18 12:00       ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220817130342.568396-6-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).