[RFC v2 2/3] platform/x86/amd: pmc: Report duration of time in deepest hw state

From: Mario Limonciello <mario.limonciello@amd.com>
To: Sven van Ashbrook <svenva@chromium.org>,
	Rafael J Wysocki <rafael@kernel.org>, <linux-pm@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	<rrangel@chromium.org>, Rajat Jain <rajatja@google.com>,
	David E Box <david.e.box@intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	<linux-kernel@vger.kernel.org>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	Mark Gross <markgross@kernel.org>
Subject: [RFC v2 2/3] platform/x86/amd: pmc: Report duration of time in deepest hw state
Date: Thu, 10 Nov 2022 00:47:22 -0600	[thread overview]
Message-ID: <20221110064723.8882-3-mario.limonciello@amd.com> (raw)
In-Reply-To: <20221110064723.8882-1-mario.limonciello@amd.com>

amd_pmc displays a warning when a suspend didn't get to the deepest
state and a dynamic debugging message with the duration if it did.

Rather than logging to dynamic debugging the duration spent in the
deepest state, report this to the standard kernel reporting infrastructure
that can be accessed from sysfs.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/platform/x86/amd/pmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c
index 96e790e639a2..e583bf966f47 100644
--- a/drivers/platform/x86/amd/pmc.c
+++ b/drivers/platform/x86/amd/pmc.c
@@ -363,9 +363,7 @@ static void amd_pmc_validate_deepest(struct amd_pmc_dev *pdev)
 
 	if (!table.s0i3_last_entry_status)
 		dev_warn(pdev->dev, "Last suspend didn't reach deepest state\n");
-	else
-		dev_dbg(pdev->dev, "Last suspend in deepest state for %lluus\n",
-			 table.timein_s0i3_lastcapture);
+	pm_set_hw_state_residency(table.s0i3_last_entry_status ? table.timein_s0i3_lastcapture : 0);
 }
 #endif
 
-- 
2.34.1

